Re: pkg/42575: x11/libxdg-basedir doesn't honor PKG_SYSCONFDIR

[Pierre Allegraud <pallegra%gmail.com@localhost>]

The following reply was made to PR pkg/42575; it has been noted by GNATS.

From: Pierre Allegraud <pallegra%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/42575: x11/libxdg-basedir doesn't honor PKG_SYSCONFDIR
Date: Sat, 9 Jan 2010 17:37:16 +0100

 2010/1/9 OBATA Akio <obache%netbsd.org@localhost>:
 > The following reply was made to PR pkg/42575; it has been noted by GNATS.
 >
 > From: "OBATA Akio" <obache%netbsd.org@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc:
 > Subject: Re: pkg/42575: x11/libxdg-basedir doesn't honor PKG_SYSCONFDIR
 > Date: Sat, 09 Jan 2010 23:04:54 +0900
 >
 > =A0On Mon, 04 Jan 2010 09:10:01 +0900, <pallegra%gmail.com@localhost> wrote:
 >
 > =A0>> Description:
 > =A0> Packages compiled with x11/libxdg-basedir are searching their config=
  files somewhere in /etc/xdg instead of ${PKG_SYSCONFDIR}/xdg.
 > =A0>
 > =A0> Could you check my quick and dirty fix, and, if it's correct, commit=
  it, please ?
 > =A0>> How-To-Repeat:
 > =A0>
 > =A0>> Fix:
 > =A0> It works for me...
 > =A0>
 > =A0>
 > =A0> Index: Makefile
 > =A0> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > =A0> RCS file: /cvsroot/pkgsrc/x11/libxdg-basedir/Makefile,v
 > =A0> retrieving revision 1.1.1.1
 > =A0> diff -u -r1.1.1.1 Makefile
 > =A0> --- Makefile 8 Nov 2009 18:26:15 -0000 =A0 =A0 =A0 1.1.1.1
 > =A0> +++ Makefile 3 Jan 2010 23:55:26 -0000
 > =A0> @@ -16,6 +16,12 @@
 > =A0> =A0USE_LIBTOOL=3D =A0 =A0 =A0 =A0yes
 > =A0> =A0USE_TOOLS+=3D pkg-config
 > =A0>+SUBST_CLASSES+=3D =A0 =A0 =A0 =A0 =A0 =A0 =A0xdgetc
 > =A0> +SUBST_MESSAGE.xdgetc=3D =A0 =A0 =A0 Fixing sysconfdir paths
 > =A0> +SUBST_STAGE.xdgetc=3D pre-build
 > =A0> +SUBST_FILES.xdgetc=3D src/basedir.c
 > =A0> +SUBST_SED.xdgetc=3D =A0 -e "s,DIR_SEPARATOR_STR \"etc\",\"${PKG_SYS=
 CONFDIR}\","
 > =A0> +
 > =A0> =A0PKGCONFIG_OVERRIDE+=3D =A0 =A0 =A0 =A0pkgconfig/libxdg-basedir.pc=
 .in
 > =A0> .include "../../mk/bsd.pkg.mk"
 >
 > =A0/usr/local/share for XDG_DATA_DIRS also may be replaced with ${PREFIX}=
 /share.
 >
 > =A0From XDG Base Directory Specification:
 > =A0 http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.htm=
 l
 >
 > =A0"If $XDG_DATA_DIRS is either not set or empty, a value equal to /usr/l=
 ocal/share/:/usr/share/ should be used."
 > =A0"If $XDG_CONFIG_DIRS is either not set or empty, a value equal to /etc=
 /xdg should be used."
 >
 > =A0For pkgsrc which is prefered?
 > =A0 Replace default value with pkgsrc's one? (/etc with ${PKG_SYSCONFDIR}=
  and /usr/local/share with ${PREFIX}/share)
 > =A0 Add pkgsrc's one to default list? (${PKG_SYSCONFIDIR}:/etc for XDG_CO=
 NDIG_DIRS and ${PREFIX}/share:/usr/local/share:/usr/share for XDG_DATA_DIRS=
 )
 >
 >
 Good point !
 Technically, adding or replacing can be handled easily with a patch or
 SUBST tools.
 I think adding pkgsrc's paths is better than replacing: maybe a
 program from base (eventually freedesktop X.org) follows xdg base
 directory specification, but doesn't use libxcb...