pkg/42757: devel/hdf5's configure reverses order of CPPFLAGS

[Taylor R Campbell <campbell%mumble.net@localhost>]

>Number:         42757
>Category:       pkg
>Synopsis:       devel/hdf5's configure reverses order of CPPFLAGS
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Feb 06 18:40:00 +0000 2010
>Originator:     Taylor R Campbell <campbell%mumble.net@localhost>
>Release:        pkgsrc-2009Q4
>Organization:
>Environment:
>Description:

        devel/hdf5's top-level configure script reverses the order of
        the CPPFLAGS that were passed as arguments to or through the
        environment of the script, because of the line

                TEMP_CPPFLAGS="$d $TEMP_CPPFLAGS"

        toward the end of the script.  On Mac OS X, pkgsrc passes
        `-isystem /usr/include' in CPPFLAGS, which makes GCC very
        confused when it receives `/usr/include -isystem'.

>How-To-Repeat:

        Build devel/hdf5 on Mac OS X.

>Fix:

        Patch the script to change the aforementioned line to:

                TEMP_CPPFLAGS="$TEMP_CPPFLAGS $d"

        I have sent a report of this upstream to help%hdfgroup.org.@localhost

        The following patch updates the patches in devel/hdf5 to do
        this for now.

Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/devel/hdf5/distinfo,v
retrieving revision 1.25
diff -p -u -r1.25 distinfo
--- distinfo    15 Nov 2009 15:50:50 -0000      1.25
+++ distinfo    6 Feb 2010 18:27:01 -0000
@@ -4,8 +4,8 @@ SHA1 (hdf5-1.6.10.tar.gz) = ccac43984197
 RMD160 (hdf5-1.6.10.tar.gz) = 7fd773f80265b5d8afc5c5765c499c22bd22f0c8
 Size (hdf5-1.6.10.tar.gz) = 7435318 bytes
 SHA1 (patch-aa) = 8e02e2b5decde21bb7d223f3870330832db399ba
-SHA1 (patch-ab) = aa4911184b72d4818f6e65d3adf86110db9bd379
-SHA1 (patch-ac) = 77e3762e4e41274550cb1a25f4a1c2ffaa45dcdf
+SHA1 (patch-ab) = 066915e86cb279f8941bca5dd81d666ccc75e974
+SHA1 (patch-ac) = e6c7e27b6487cb98816a2d358fa1399a1c687f55
 SHA1 (patch-ad) = 0b58c169e0d12cc25fc6206fc49086a89d2836b7
 SHA1 (patch-ba) = 1ba84ee22c3307100a2c8d3df4dfb2037be8e773
 SHA1 (patch-bb) = bcfd87df515d64471f881d4d10c894d89a6bc56e
Index: patches/patch-ab
===================================================================
RCS file: /cvsroot/pkgsrc/devel/hdf5/patches/patch-ab,v
retrieving revision 1.8
diff -p -u -r1.8 patch-ab
--- patches/patch-ab    25 Sep 2007 01:22:15 -0000      1.8
+++ patches/patch-ab    6 Feb 2010 18:27:01 -0000
@@ -1,12 +1,24 @@
 $NetBSD: patch-ab,v 1.8 2007/09/25 01:22:15 dmcmahill Exp $
 
 Adds missing -lsocket needed on solaris for socket(), bind(), and friends.
+Unreverses order of CPPFLAGS.
 
---- configure.in.orig  2007-08-16 12:13:34.000000000 -0400
-+++ configure.in       2007-09-24 08:44:58.668063000 -0400
-@@ -675,4 +675,5 @@
+--- configure.in.orig  2009-11-10 13:02:05.000000000 -0500
++++ configure.in       2010-02-06 13:13:08.000000000 -0500
+@@ -668,6 +668,7 @@
+ 
  if test "`uname`" = "SunOS" -o "`uname -sr`" = "HP-UX B.11.00"; then
    dnl ...for Solaris
 +  AC_CHECK_LIB([socket], [socket])
    AC_CHECK_LIB([nsl], [xdr_int])
  fi
+ 
+@@ -2172,7 +2173,7 @@
+         d="-I${ROOT}/${d}"
+         ;;
+     esac
+-    TEMP_CPPFLAGS="$d $TEMP_CPPFLAGS"
++    TEMP_CPPFLAGS="$TEMP_CPPFLAGS $d"
+   done
+   CPPFLAGS=$TEMP_CPPFLAGS
+ fi
Index: patches/patch-ac
===================================================================
RCS file: /cvsroot/pkgsrc/devel/hdf5/patches/patch-ac,v
retrieving revision 1.10
diff -p -u -r1.10 patch-ac
--- patches/patch-ac    11 Sep 2008 10:27:52 -0000      1.10
+++ patches/patch-ac    6 Feb 2010 18:27:01 -0000
@@ -1,8 +1,8 @@
 $NetBSD: patch-ac,v 1.10 2008/09/11 10:27:52 adam Exp $
 
---- configure.orig     2008-02-01 04:08:54.000000000 +0100
-+++ configure
-@@ -8822,6 +8822,77 @@ fi
+--- configure.orig     2009-11-10 13:11:34.000000000 -0500
++++ configure  2010-02-06 13:13:28.000000000 -0500
+@@ -8808,6 +8808,77 @@
  
  if test "`uname`" = "SunOS" -o "`uname -sr`" = "HP-UX B.11.00"; then
  
@@ -80,3 +80,12 @@ $NetBSD: patch-ac,v 1.10 2008/09/11 10:2
  { echo "$as_me:$LINENO: checking for xdr_int in -lnsl" >&5
  echo $ECHO_N "checking for xdr_int in -lnsl... $ECHO_C" >&6; }
  if test "${ac_cv_lib_nsl_xdr_int+set}" = set; then
+@@ -32292,7 +32363,7 @@
+         d="-I${ROOT}/${d}"
+         ;;
+     esac
+-    TEMP_CPPFLAGS="$d $TEMP_CPPFLAGS"
++    TEMP_CPPFLAGS="$TEMP_CPPFLAGS $d"
+   done
+   CPPFLAGS=$TEMP_CPPFLAGS
+ fi