Re: pkg/41423: CenterIM unusable: ignores several keys (like enter)

[momomo%lavabit.com@localhost]

The following reply was made to PR pkg/41423; it has been noted by GNATS.

From: momomo%lavabit.com@localhost
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/41423: CenterIM unusable: ignores several keys (like enter)
Date: Mon, 8 Feb 2010 02:27:54 -0500 (EST)

 I had a similar problem (i.e. Enter key not working) on i386-netbsd.
 However, the same package (or was it CenterICQ ?) worked fine on
 alpha-netbsd.
 
 I don't think it's a keyboard issue, I believe that all actions that
 require a contact to be selected fail because the function returning
 the selected contact contains a bogus check:
 
 --- src/icqface.cc.orig        2010-01-19 16:01:41.000000000 +0100
 +++ src/icqface.cc     2010-01-19 16:02:05.000000000 +0100
 @@ -539,7 +539,7 @@
            g = 0;
        }
 
 -      if((intptr_t) c < 100) c = 0;
 +      /* if((intptr_t) c < 100) c = 0; */
 
        if(i) {
            switch(action = extk) {
 
 /**************** end of patch **************************/
 
 I looked in their source tree and it looks like this line
 was in there in a form or other since the initial import from
 CenterICQ.  To me, this looks like a guard against a bad memory
 reference that just happened to work whenever they were debugging
 a problem, and that was left in and is only seen in certain
 memory layouts (which is why it may have worked on alpha or
 other architectures or other OSes).  I can't imagine a valid
 reason to reject a contact if it lives in a certain part of the
 RAM...
 
 Regards,
 -- 
 Mo mo Mo
 
 PS: updated distinfo
 $NetBSD$
 
 SHA1 (centerim-4.22.9.tar.gz) = ebe9f4ee2064a2fa10f1084ce26083ccd295673e
 RMD160 (centerim-4.22.9.tar.gz) = 253007e466a211ec740f7843538e4f686ab95cad
 Size (centerim-4.22.9.tar.gz) = 2252262 bytes
 SHA1 (patch-aa) = 47ddb8568aa36255ad20b71d999284f023726980
 SHA1 (patch-ac) = 4ef992ed632a57e921661b1b0054beff0c0aa587
 SHA1 (patch-ad) = bfe19ca98facfbb23a87dd28a176980fb4e986de
 SHA1 (patch-av) = 05758183016fb1bb297c9c3d2c0606e6a66f9901
 SHA1 (patch-bb) = 7312d496cdde7f619eff6bfef6025fe9be14529d
 SHA1 (patch-bc) = a9e8bfef2d224fb78b78b761f611226444d488e6