pkg/42868: games/4stAttack installs script that references /bin/bash

[kre%munnari.OZ.AU@localhost]

>Number:         42868
>Category:       pkg
>Synopsis:       games/4stAttack installs script that references /bin/bash
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 22 20:25:00 +0000 2010
>Originator:     Robert Elz
>Release:        NetBSD 4.0 / i386   (pkgsrc current as of 2010-02-22)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 4.0_STABLE NetBSD 4.0_STABLE 
(JADE-1.696-20080517) #9: Fri May 23 18:55:13 ICT 2008 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/4/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
        The PKG_DEVELOPER=yes test of installed scripts for
        references to non-existant interpreters finds a reference
        to /bin/bash in one of the installed scripts.

        Worse perhaps, this is just treated as a warning, rather than
        an error, so it is very easy to miss amongst all the other
        noise (I saw this one go past purely by fluke).

>How-To-Repeat:
        I use pkg_comp with NetBSD 4.0 release sets installed, and libkver
        to give a NetBSD 4.0 release build enviornment (I use X11_TYPE=modular
        instead of the x* sets.)  In case it matters, I am currently one rev
        down on pkg_install versions - I am using the 20100204 version, for
        no particularly good reason.

        In that environment, after successfully building and installing
        games/4stAttack (4stAttack-2.1.4nb8), just before building a
        binary package, observe the following scroll past ...

=> Checking for non-existent script interpreters in 4stAttack-2.1.4nb8
WARNING: [check-interpreter.mk] The interpreter "/bin/bash" of 
"/usr/pkg/share/4stAttack/themeresizer.sh" does not exist.

        Note that (in this environment, PR 42820 needs to be handled to
        allow pulseaudio to build before it is possible to get this far,
        however this same problem most likely exists in NetBSD 5 and
        cirrent installs of this package, in which case pulseaudio would
        be fine without that PR being handled first.

>Fix:
        ??   One of pkgsrc's magic invocations I believe.
        A revbump will be needed when this is fixed.

        More importantly, this warning should be an error (just like
        when the file-check fail) when PKG_DEVELOPER=yes