Re: pkg/42991 (p7zip - Makefile (licenses) broken)

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/42991; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
pkgsrc-bugs%netbsd.org@localhost,
        rodo%zlug.org@localhost
Subject: Re: pkg/42991 (p7zip - Makefile (licenses) broken)
Date: Tue, 23 Mar 2010 18:52:55 +0000

 On Tue, Mar 23, 2010 at 06:40:09PM +0000, Joerg Sonnenberger wrote:
  >> I think I understand:
  >> it should not be saying
  >> ERROR: You can mark the license ``license'' as acceptable by adding
  >> ERROR:     ACCEPTABLE_LICENSES+= license
  >>
  >> because that's nonsense.
  >  
  >  What else? Should it second guess what the best for the user is?
  >  Do you want to implement a SAT resolver?
 
 There are various things it could say that are not nonsense, such as
 
 ERROR: This package has set PKG_FAIL_REASON:
 ERROR: foo-1.0 has an unacceptable license condition: 
 ERROR:     foo-license AND bar-license AND modified-bsd
 ERROR: The following license(s) are not accepted:
 ERROR:     foo-license bar-license
 ERROR: To build this package you must accept some suitable combination
 ERROR: of these. To accept a license called ``license'', add
 ERROR:     ACCEPTABLE_LICENSES+= license
 ERROR: to /etc/mk.conf or add
 ERROR:     ACCEPTABLE_LICENSES= license
 ERROR: to /usr/pkg/etc/pkg_install.conf.
 
  >  > Relatedly, make show-license doesn't work for expressions on licenses,
  >  > either - it says e.g.
  >  >   Generic gnu-gpl-v3 OR modified-bsd information not available
  >  > for "LICENSE=gnu-gpl-v3 OR modified-bsd
  >  > ".
  >  
  >  If you want to fix it, drop () AND OR, sort, unify and loop over the
  >  result...
 
 That or suggest "make show-license LICENSE=foo" for each one, which is
 probably better since many licenses are large.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost