pkg/43077: audio/mpg123 does not compile on Linux

[schaecsn%gmx.net@localhost]

>Number:         43077
>Category:       pkg
>Synopsis:       audio/mpg123 does not compile on Linux
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 30 04:05:00 +0000 2010
>Originator:     Stefan
>Release:        
>Organization:
>Environment:
Linux vaio 2.6.29.6 #2 Mon Dec 7 17:31:46 CST 2009 i686 Intel(R) Pentium(R) 4 
CPU 2.80GHz GenuineIntel GNU/Linux
>Description:
audio/mpg123 from pkgsrc-current does not compile on Linux Slackware 13 (didn't 
try NetBSD).
>How-To-Repeat:
bmake
>Fix:
audio/mpg123 from pkgsrc-current does not compile on Linux Slackware 13 (didn't 
try NetBSD).

audio/mpg123:

# bmake

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../src -I../../src/libmpg123 
-DOPT_MULTI -DOPT_GENERIC -DOPT_GENERIC_DITHER -DOPT_I386 -DOPT_I586 
-DOPT_I586_DITHER -DOPT_MMX -DOPT_3DNOW -DOPT_3DNOWEXT -DOPT_SSE 
-DREAL_IS_FLOAT -I/tmp/pkgsrc/audio/mpg123/work/.buildlink/include -O2 
-fomit-frame-pointer -funroll-all-loops -finline-functions -ffast-math 
-Wno-error -O2 -march=pentium4 -MT output_oss_la-oss.lo -MD -MP -MF 
.deps/output_oss_la-oss.Tpo -c oss.c  -fPIC -DPIC -o .libs/output_oss_la-oss.o
oss.c: In function 'open_oss':
oss.c:170: error: 'DEVOSSAUDIO' undeclared (first use in this function)
oss.c:170: error: (Each undeclared identifier is reported only once
oss.c:170: error: for each function it appears in.)
oss.c:179: error: 'DEVOSSSOUND' undeclared (first use in this function)
make[3]: *** [output_oss_la-oss.lo] Error 1



DEVOSSAUDIO is set in ../../mk/oss.buildlink3.mk

A fix would be to include in the Makefile

--- snip ---------------------------------------------------------------
CPPFLAGS+=   -DDEVOSSAUDIO="\"${DEVOSSAUDIO}\""
CPPFLAGS+=   -DDEVOSSSOUND="\"${DEVOSSSOUND}\""

.include "../../mk/oss.buildlink3.mk"
--- snip ---------------------------------------------------------------


It looks to me that audio/mpg123 should no be used anymore as most 
configuration choices are in audio/mpg123-XXX/, but audio/mpg123-oss does not 
compile on Slackware 13, either:


audio/mpg123-oss is including ../../mk/oss.buildlink3.mk, but does not allow to 
compile the port on linux

audio/mpg123-oss:

# bmake
ERROR: This package is only available for these platforms: NetBSD-*-* 
FreeBSD-*-* OpenBSD-*-* SunOS-*-* DragonFly-*-*.
ERROR: This package has set PKG_FAIL_REASON:
ERROR: mpg123-oss-1.10.1 is not available for Linux-2.6.29.6-i386

Letting audio/mpg123 compile on Linux does not work. Somehow, the CPPFLAGS 
defined in the Makefile are not passed to the actual compilation.

Adding the above code snippet into audio/mpg123/Makefile would fix this.