pkg/43098: devel/m4: syscmd and esyscmd brocken on DragonFly

[gisenmann%web.de@localhost]

>Number:         43098
>Category:       pkg
>Synopsis:       devel/m4: syscmd and esyscmd brocken on DragonFly
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 01 18:05:00 +0000 2010
>Originator:     Goetz Isenmann
>Release:        DragonFly 2.6 prerelease
>Organization:
>Environment:
i386 DragonFly v2.6.0.36.gf0294-RELEASE
>Description:
m4 has (via includes gnulib) in lib/spawn.in.h

# define POSIX_SPAWN_SETSIGMASK         0x08
# define POSIX_SPAWN_SETSCHEDPARAM      0x10
# define POSIX_SPAWN_SETSCHEDULER       0x20

but DragonFly has in /usr/include/spawn.h

#define POSIX_SPAWN_SETSCHEDPARAM       0x04
#define POSIX_SPAWN_SETSCHEDULER        0x08
#define POSIX_SPAWN_SETSIGMASK          0x20

The m4 builtins syscmd and esyscmd use the internal SETSIGMASK value 0x08.
This results in a: syscmd subprocess failed: Operation not permitted.

>How-To-Repeat:
(cd work/m4-1.4.14 && gmake check)

>Fix:
A simple fix DragonFly (as suggested for FreeBSD 8.0 in
www.mail-archive.com/bug-m4%gnu.org@localhost/msg02742.html)

--- lib/spawn.in.h.orig 2010-03-18 20:09:42 +0100
+++ lib/spawn.in.h      2010-03-18 20:09:49 +0100
@@ -110,6 +110,7 @@
 
 
 /* Flags to be set in the `posix_spawnattr_t'.  */
+#if !@HAVE_POSIX_SPAWN@
 #if @REPLACE_POSIX_SPAWN@
 /* Use the values from the system, for better compatibility.  */
 /* But this implementation does not support AIX extensions.  */
@@ -122,6 +123,7 @@
 # define POSIX_SPAWN_SETSCHEDPARAM      0x10
 # define POSIX_SPAWN_SETSCHEDULER       0x20
 #endif
+#endif
 /* A GNU extension.  Use the next free bit position.  */
 #define POSIX_SPAWN_USEVFORK \
   ((POSIX_SPAWN_RESETIDS | (POSIX_SPAWN_RESETIDS - 1)                   \

The gnulib HEAD version contains a better fix for this and
probably also other problems.