Re: pkg/43162: audio/pulseaudio is trying to modify /lib

[rudolf <netbsd%eq.cz@localhost>]

The following reply was made to PR pkg/43162; it has been noted by GNATS.

From: rudolf <netbsd%eq.cz@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/43162: audio/pulseaudio is trying to modify /lib
Date: Sun, 18 Apr 2010 13:20:39 +0200

 This is a multi-part message in MIME format.
 --------------000302070009040902070807
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Hi,
 
 prefixing udevrulesdir with $(PREFIX) in src/Makefile.am file of the 
 package helps with the "writing to read-only /lib" problem:
 
 udevrulesdir=$(PREFIX)/lib/udev/rules.d
 
 I've modified the patch-ad file for this (attached).
 
 IMO it is also useful to configure the package with "--disable-udev" on 
 non-Linux OSes, but it itself doesn't prevent the package to write to 
 /lib/udev. (attached Makefile patch)
 
 r.
 
 
 
 --------------000302070009040902070807
 Content-Type: text/plain;
  name="patch-ad"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="patch-ad"
 
 --- src/Makefile.am.orig       2010-04-18 09:56:15.000000000 +0200
 +++ src/Makefile.am
 @@ -26,13 +26,13 @@
  
  pulseincludedir=$(includedir)/pulse
  pulsecoreincludedir=$(includedir)/pulsecore
 -pulseconfdir=$(sysconfdir)/pulse
 +pulseconfdir=$(EGDIR)
  pulselibexecdir=$(libexecdir)/pulse
 -xdgautostartdir=$(sysconfdir)/xdg/autostart
 +xdgautostartdir=$(PREFIX)/share/gnome/autostart
  alsaprofilesetsdir=$(datadir)/pulseaudio/alsa-mixer/profile-sets
  alsapathsdir=$(datadir)/pulseaudio/alsa-mixer/paths
 -udevrulesdir=/lib/udev/rules.d
 -dbuspolicydir=$(sysconfdir)/dbus-1/system.d
 +udevrulesdir=$(PREFIX)/lib/udev/rules.d
 +dbuspolicydir=$(EGDIR)
  
  ###################################
  #            Defines              #
 @@ -42,7 +42,7 @@ PA_BINARY=$(bindir)/pulseaudio$(EXEEXT)
  if OS_IS_WIN32
  PA_DEFAULT_CONFIG_DIR=%PULSE_ROOT%
  else
 -PA_DEFAULT_CONFIG_DIR=$(pulseconfdir)
 +PA_DEFAULT_CONFIG_DIR=$(sysconfdir)/pulse
  endif
  
  ###################################
 @@ -1419,7 +1419,7 @@ module_x11_cork_request_la_LIBADD = $(AM
  # OSS
  
  liboss_util_la_SOURCES = modules/oss/oss-util.c modules/oss/oss-util.h
 -liboss_util_la_LDFLAGS = -avoid-version
 +liboss_util_la_LDFLAGS = -avoid-version $(LIBOSSAUDIO)
  liboss_util_la_LIBADD = libpulsecore-@PA_MAJORMINORMICRO@.la 
libpulsecommon-@PA_MAJORMINORMICRO@.la libpulse.la
  
  module_oss_la_SOURCES = modules/oss/module-oss.c
 
 --------------000302070009040902070807
 Content-Type: text/plain;
  name="pulseaudio_makefile_udev.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="pulseaudio_makefile_udev.diff"
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/audio/pulseaudio/Makefile,v
 retrieving revision 1.35
 diff -u -r1.35 Makefile
 --- Makefile   22 Feb 2010 21:48:03 -0000      1.35
 +++ Makefile   18 Apr 2010 11:18:38 -0000
 @@ -44,6 +44,8 @@
  CONF_FILES+=  ${EGDIR}/pulseaudio-system.conf \
                ${PKG_SYSCONFBASE}/dbus-1/system.d/pulseaudio-system.conf
  
 +.include "../../mk/bsd.prefs.mk"
 +
  CONFIGURE_ARGS+=      --sysconfdir=${PKG_SYSCONFBASE}
  CONFIGURE_ARGS+=      --localstatedir=${VARBASE}
  CONFIGURE_ARGS+=      --with-system-user=${PULSE_USER}
 @@ -51,6 +53,9 @@
  CONFIGURE_ARGS+=      --with-realtime-group=${PULSE_GROUP_REALTIME}
  CONFIGURE_ARGS+=      --with-access-group=${PULSE_GROUP_ACCESS}
  CONFIGURE_ARGS+=      --disable-tcpwrap
 +.if ${OPSYS} != "Linux"
 +CONFIGURE_ARGS+=      --disable-udev
 +.endif
  MAKE_ENV+=            EGDIR=${EGDIR}
  
  SPECIAL_PERMS+=               bin/pulseaudio ${SETUID_ROOT_PERMS}
 @@ -61,7 +66,6 @@
  SUBST_FILES.padsp=    src/utils/padsp
  SUBST_SED.padsp=      -e 's@libpulsedsp\.so@${PREFIX}/lib/&@'
  
 -.include "../../mk/bsd.prefs.mk"
  .if ${OPSYS} == "NetBSD"
  # broken test for TLS
  CONFIGURE_ENV+=               cc_cv_tls___thread=no
 
 --------------000302070009040902070807--