pkg/43198: www/seamonkey-l10n bad make var expansion expression (NetBSD 4.0) +FIX

[kre%munnari.OZ.AU@localhost]

>Number:         43198
>Category:       pkg
>Synopsis:       www/seamonkey-l10n bad make var expansion expression (NetBSD 
>4.0) +FIX
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 23 14:35:00 +0000 2010
>Originator:     Robert Elz
>Release:        NetBSD 4.0 / i386    pkgsrc current (HEAD) 2010-04-23
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 4.0_STABLE NetBSD 4.0_STABLE 
(JADE-1.696-20080517) #9: Fri May 23 18:55:13 ICT 2008 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/4/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
        The expression used to generate the names of the language pack
        distfiles for seamonkey isn't handled by (at least) NetBSD 4's
        version of make (my guess is something related to the $$ but
        I didn't bother to analyse the failure, as it is trivial
        to change to an expression that does work - and what's more,
        is simpler).

        Also noticed a minor typo in the MESSAGE file.

        Patch to fix both those appended.

>How-To-Repeat:
        I use pkg_comp (blah blah, that isn't even slightly
        related here) ...

        What happens is ...

PKG_COMP ==> Building and installing www/seamonkey-l10n
make: RE substitution error: empty (sub)expression
make: Unclosed substitution for SM_LOCALES (/ missing)
make: RE substitution error: empty (sub)expression
make: Unclosed substitution for SM_LOCALES (/ missing)
make: RE substitution error: empty (sub)expression
make: Unclosed substitution for SM_LOCALES (/ missing)
make: RE substitution error: empty (sub)expression
make: Unclosed substitution for SM_LOCALES (/ missing)

        (many times - most likely once for each word in SM_LOCALES
        but I didn't bother counting).    This happens n each reference
        to the pkgsrc makefile (so for "make fetch" or "make" or ...)

>Fix:

        Apply the following patch...  (no revbumps needed, there should be
        no change to the resulting package if it worked before).

        I have tested this, it works fine for me with this change.

Index: MESSAGE
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/www/seamonkey-l10n/MESSAGE,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 MESSAGE
--- MESSAGE     22 Apr 2010 16:58:23 -0000      1.1.1.1
+++ MESSAGE     23 Apr 2010 14:23:40 -0000
@@ -4,5 +4,5 @@
 To change the language in Seamonkey, navigate to about:config and edit
 the general.useragent.locale property. 
 Alternatively you can install the "Quick Locale Switcher" addon from:
-ttps://addons.mozilla.org/en-US/seamonkey/addon/1333 .
+https://addons.mozilla.org/en-US/seamonkey/addon/1333 .
 ===========================================================================
Index: Makefile
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/www/seamonkey-l10n/Makefile,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile
--- Makefile    22 Apr 2010 16:58:23 -0000      1.1.1.1
+++ Makefile    23 Apr 2010 14:13:39 -0000
@@ -23,7 +23,7 @@
                        tr
 
 EXTENSIONS_DIR=                ${PREFIX}/lib/seamonkey/extensions
-XPI_FILES=             
${SM_LOCALES:C/^/seamonkey-${SM_VER}./:C/$$/.langpack.xpi/}
+XPI_FILES=             ${SM_LOCALES:C/.*/seamonkey-${SM_VER}.&.langpack.xpi/}
 
 .include "../../devel/xulrunner/xpi.mk"
 .include "../../mk/bsd.pkg.mk"