pkg/43206: building bmake-20100414 fails due to $MAKESYSPATH not set correctly

[jan.lentfer%web.de@localhost]

>Number:         43206
>Category:       pkg
>Synopsis:       building bmake-20100414 fails due to $MAKESYSPATH not set 
>correctly
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 25 12:05:00 +0000 2010
>Originator:     Jan Lentfer
>Release:        DragonFly BSD 2.7-DEV
>Organization:
DragonFly BSD
>Environment:
DragonFly atom.lan.net 2.7-DEVELOPMENT DragonFly v2.7.2.21.g4fee1-DEVELOPMENT
>Description:
When running bmake in devel/bmake the build will fail with
bmake: "/usr/share/mk/bsd.cpu.mk" line 48: Unknown directive
bmake: "/usr/share/mk/bsd.cpu.mk" line 49: Unknown directive
bmake: Fatal errors encountered -- cannot continue

This happens because /usr/shake/mk/sys.mk is included which includes bsd.cpu.mk.
bmake should not look in /usr/share/mk at all, but use /usr/pkg/share/mk. I 
could track it down to be a Problem in "boot-strap" when setting 
MAKESYSPATH/shared_dir by addin "set -vx" to boot-strap:

MAKESYSPATH="$share_dir/mk:/usr/share/mk"
+ MAKESYSPATH=/share/mk:/usr/share/mk

So it is clear that MAKESYSPATH does not contain /usr/pkg/share/mk at all.
>How-To-Repeat:
cd /usr/pkgsrc/devel/bmake
bmake all

on DragonFly
>Fix:
This patch sets shared_dir explicitly and the build works then. But I think the 
underlying problem is deeper than that. So this should be looked upon as work 
around that works on DragonFly. Haven't tested it anywhere else.

diff --git a/devel/bmake/Makefile b/devel/bmake/Makefile
index 7da5cc1..c2d6448 100644
--- a/devel/bmake/Makefile
+++ b/devel/bmake/Makefile
@@ -29,6 +29,7 @@ INSTALLATION_DIRS=    bin ${PKGMANDIR}/man1

 BOOTSTRAP_ARGS=                -q -o ${OPSYS} --prefix=${PREFIX} \
                        --with-default-sys-path=${makesyspath} \
+                       --share /usr/pkg/share \
                        --mksrc none --sysconfdir=${PKG_SYSCONFDIR:Q}

 .include "../../mk/bsd.prefs.mk"