pkgsrc-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/43363: update emulators/simh V3.8-1, with fixes for build on Linux
The following reply was made to PR pkg/43363; it has been noted by GNATS.
From: "OBATA Akio" <obache%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc:
Subject: Re: pkg/43363: update emulators/simh V3.8-1, with fixes for build on
Linux
Date: Wed, 26 May 2010 21:28:27 +0900
On Wed, 26 May 2010 20:30:00 +0900, <tsutsui%ceres.dti.ne.jp@localhost> wrote:
> * update DISTNAME, PKGNAME, and distinfo for V3.8-1
OK.
> * add MAKEFLAGS in pkgsrc Makefile to handle OSTYPE in dist makefile
MAKE_FLAGS should be used instead.
(see The pkgsrc guide 22.1)
> * revise patch-aa to handle non-NetBSD OSes in makefile
> (Darwin and Solaris are untested)
How about minimalize patch and use gmake (USE_TOOLS+=gmake)?
And it will be acceptable for upstream.
> * update patch-ac for upstream cosmetics
Seems OK.
But do you know why this patch is required?
> * rewrite patch-ad to get proper inline defs,
> though upstream seems to disable SIM_INLINE macro
I feel this patch should be removed.
> * remove INSTALL_DATA_DIR per pkglint
OK.
Home |
Main Index |
Thread Index |
Old Index