pkg/43784: devel/mercurial: PLIST issue on Linux [patch]

[cheusov%tut.by@localhost]

>Number:         43784
>Category:       pkg
>Synopsis:       devel/mercurial: PLIST issue on Linux [patch]
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Aug 21 12:15:00 +0000 2010
>Originator:     Aleksey Cheusov
>Release:        NetBSD 5.1_RC3
>Organization:
>Environment:
System: NetBSD asrock.chizhovka.net 5.1_RC3 NetBSD 5.1_RC3 (GENERIC) #1: Mon 
Jun 28 00:06:07 EEST 2010 
cheusov%asrock.chizhovka.net@localhost:/srv/obj/sys/arch/amd64/compile/GENERIC 
amd64
Architecture: x86_64
Machine: amd64
>Description:
mercurial fails to build due to problems with PLIST.
=> Checking file-check results for mercurial-1.6.2
ERROR: ************************************************************
ERROR: The following files are in /usr/pkg but not in the PLIST:
ERROR:         
/tmp/obj_pkgsrc/devel/mercurial/work/.destdir/usr/pkg/lib/python2.6/site-packages/hgext/inotify/__init__.py
ERROR:         
/tmp/obj_pkgsrc/devel/mercurial/work/.destdir/usr/pkg/lib/python2.6/site-packages/hgext/inotify/__init__.pyc
ERROR:         
/tmp/obj_pkgsrc/devel/mercurial/work/.destdir/usr/pkg/lib/python2.6/site-packages/hgext/inotify/__init__.pyo
...
*** Error code 1

>How-To-Repeat:
Build package on Linux 2.6
>Fix:
If I understand correctly setup.py, inotify is enabled on Linux-2.6 only.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/mercurial/Makefile,v
retrieving revision 1.45
diff -u -r1.45 Makefile
--- Makefile    7 Aug 2010 06:24:05 -0000       1.45
+++ Makefile    21 Aug 2010 12:10:15 -0000
@@ -28,5 +28,11 @@
        ${INSTALL_DATA} ${WRKSRC}/README  \
                ${DESTDIR}${PREFIX}/share/doc/mercurial
 
+.include "../../mk/bsd.prefs.mk"
+
+.if ${OPSYS} == "Linux" && empty(OS_VERSION:M2.4.*) && empty(OS_VERSION:M2.2.*)
+PLIST_SRC+=    ${.CURDIR}/PLIST ${.CURDIR}/PLIST.inotify
+.endif
+
 .include "../../lang/python/extension.mk"
 .include "../../mk/bsd.pkg.mk"
Index: PLIST.inotify
===================================================================
RCS file: PLIST.inotify
diff -N PLIST.inotify
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ PLIST.inotify       21 Aug 2010 12:10:15 -0000
@@ -0,0 +1,23 @@
+@comment $NetBSD: PLIST,v 1.20 2010/07/05 09:11:14 wiz Exp $
+${PYSITELIB}/hgext/inotify/__init__.py
+${PYSITELIB}/hgext/inotify/__init__.pyc
+${PYSITELIB}/hgext/inotify/__init__.pyo
+${PYSITELIB}/hgext/inotify/client.py
+${PYSITELIB}/hgext/inotify/client.pyc
+${PYSITELIB}/hgext/inotify/client.pyo
+${PYSITELIB}/hgext/inotify/common.py
+${PYSITELIB}/hgext/inotify/common.pyc
+${PYSITELIB}/hgext/inotify/common.pyo
+${PYSITELIB}/hgext/inotify/linux/__init__.py
+${PYSITELIB}/hgext/inotify/linux/__init__.pyc
+${PYSITELIB}/hgext/inotify/linux/__init__.pyo
+${PYSITELIB}/hgext/inotify/linux/_inotify.so
+${PYSITELIB}/hgext/inotify/linux/watcher.py
+${PYSITELIB}/hgext/inotify/linux/watcher.pyc
+${PYSITELIB}/hgext/inotify/linux/watcher.pyo
+${PYSITELIB}/hgext/inotify/linuxserver.py
+${PYSITELIB}/hgext/inotify/linuxserver.pyc
+${PYSITELIB}/hgext/inotify/linuxserver.pyo
+${PYSITELIB}/hgext/inotify/server.py
+${PYSITELIB}/hgext/inotify/server.pyc
+${PYSITELIB}/hgext/inotify/server.pyo