Re: pkg/43845 ([PATCH] security/gnupg2 and security/dirmngr should not include pth/buildlink3.mk)

[Matthias Drochner <M.Drochner%fz-juelich.de@localhost>]

The following reply was made to PR pkg/43845; it has been noted by GNATS.

From: Matthias Drochner <M.Drochner%fz-juelich.de@localhost>
To: Rumko <rumcic%gmail.com@localhost>
Cc: <M.Drochner%fz-juelich.de@localhost>, <gnats-bugs%netbsd.org@localhost>,
        <pkg-manager%netbsd.org@localhost>, <pkgsrc-bugs%netbsd.org@localhost>, 
<gnats-admin%netbsd.org@localhost>,
        <drochner%netbsd.org@localhost>
Subject: Re: pkg/43845 ([PATCH] security/gnupg2 and security/dirmngr should 
 not include pth/buildlink3.mk)
Date: Tue, 7 Sep 2010 12:41:08 +0200

 rumcic%gmail.com@localhost said:
 > With the following patch, gnupg2 and dirmngr still compile, but I
 > don't end up  with duplicate pthread stuff.
 
 Thanks - looks good. I was a bit concerned that it might cause
 unwanted dependencies on itself (or another pthread substitution
 pkg) in case of no native pthreads, but a test with
 PREFER_NATIVE_PTHREADS=3Dno didn't show problems.
 It still might be a bit fragile in case someone sets _PKG_PTHREAD
 to something else, but I think it is OK unless someone comes
 up with an example.
 
 > Should this be put in a new PR?
 
 Not necessary - I'll commit it in a minute.
 
 > And is "defined(PTHREAD_TYPE)" really needed?
 
 I think it is better to leave it there. While it shouldn't
 happen, with some unusual settings of PREFER_xxx variables
 or so one might end up without this variable defined, and
 bmake's error messages are rather confusing in this case.
 
 thanks & best regards
 Matthias
 
 
 
 ---------------------------------------------------------------------------=
 ---------------------
 ---------------------------------------------------------------------------=
 ---------------------
 Forschungszentrum Juelich GmbH
 52425 Juelich
 Sitz der Gesellschaft: Juelich
 Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
 Vorsitzender des Aufsichtsrats: MinDirig Dr. Karl Eugen Huthmacher
 Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender),
 Dr. Ulrich Krafft (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
 Prof. Dr. Sebastian M. Schmidt
 ---------------------------------------------------------------------------=
 ---------------------
 ---------------------------------------------------------------------------=
 ---------------------