Re: pkg/43887: building php-mysqli fails due to missing file my_compiler.h

[Kurt Schreiner <ks%ub.uni-mainz.de@localhost>]

On Fri, Sep 17, 2010 at 07:45:01AM +0000, Thomas Klausner wrote:
> The following reply was made to PR pkg/43887; it has been noted by GNATS.
> 
> From: Thomas Klausner <wiz%NetBSD.org@localhost>
> To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
> Cc: 
> Subject: Re: pkg/43887: building php-mysqli fails due to missing file
>  my_compiler.h
> Date: Fri, 17 Sep 2010 09:41:40 +0200
> 
>  On Fri, Sep 17, 2010 at 07:30:00AM +0000, ks%ub.uni-mainz.de@localhost wrote:
>  > With pkgsrc as of 17 September 2010, 7:00 GMT tying to build php-mysqli 
> fails due to "my_compiler.h" missing.
>  
>  Builds fine for me on 5.99.39/amd64.
Which version of mysql-client is installed on your (test) system?
mysql-client 5.1.49 (updated to ..50 on Sept. 08) doesn't have this
problem.

>  Please give more information on the build failure for php-mysqli.
The problem arises with the newest mysql-client 5.1.50 as there is
a new dependency on my_compiler.h in my_config.h.

From the mysql-5.1.50 Changelog:

    ------------------------------------------------------------
    revno: 3457.1.27
    committer: Davi Arnaut <Davi.Arnaut%Sun.COM@localhost>
    branch nick: mysql-5.1-bugteam
    timestamp: Wed 2010-07-14 16:39:40 -0300
    message:
      Bug#42733: Type-punning warnings when compiling MySQL --
                 strict aliasing violations.
      
      Post-merge fix: include my_compiler.h before my_attribute.h
      as the latter will undef __attribute__ if the compiler is not
      GCC. Based on the compiler version, in my_compiler.h we know
      for sure whether the aligned attribute is supported. Furthermore,
      undefining attribute might cause bugs if some system header
      uses it.
    ------------------------------------------------------------


Building php-mysqli w/o my patches applied fails with:

...
In file included from 
/u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli/mysqli_nonapi.c:24:
/u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli/config.h:68:1: 
warning: this is the location of the previous definition
In file included from 
/u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli/php_mysqli_structs.h:57,
--- mysqli_prop.lo ---
/u/NetBSD/pkgobj/databases/php-mysqli/work/.buildlink/include/mysql/my_global.h:626:25:
 error: my_compiler.h: No such file or directory
--- mysqli_nonapi.lo ---
                 from 
/u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli/mysqli_nonapi.c:32:
/u/NetBSD/pkgobj/databases/php-mysqli/work/.buildlink/include/mysql/my_global.h:626:25:
 error: my_compiler.h: No such file or directory
--- mysqli_api.lo ---
In file included from 
/u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli/php_mysqli_structs.h:57,
--- mysqli_nonapi.lo ---
*** [mysqli_nonapi.lo] Error code 1

make: stopped in /u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli
--- mysqli_api.lo ---
                 from 
/u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli/mysqli_api.c:33:
/u/NetBSD/pkgobj/databases/php-mysqli/work/.buildlink/include/mysql/my_global.h:626:25:
 error: my_compiler.h: No such file or directory
--- mysqli_prop.lo ---
*** [mysqli_prop.lo] Error code 1

make: stopped in /u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli
...

Kurt