Re: pkg/43316: tnftp on HP-UX broken

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/43316; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/43316: tnftp on HP-UX broken
Date: Sun, 26 Sep 2010 23:52:08 +0000

 (not sent to gnats)
 
    ------
 
 From: Wojciech Galazka <wojciech.galazka%gmail.com@localhost>
 To: pkgsrc-bugs%NetBSD.org@localhost
 Subject: Re: pkg/43316: tnftp on HP-UX broken
 Date: Tue, 14 Sep 2010 22:09:13 +0000 (UTC)
 
 Hi,
 I'm writing to tell you that simply putting the following to tnftp/Makefile 
does
 not solve this issue of non working tnftp
  
  CFLAGS.HPUX+= -D_XOPEN_SOURCE_EXTENDE
 
 Actually the problem is a bit different and I found the solution reading 
 http://www.mail-archive.com/gsoap%yahoogroups.com@localhost/msg01711.html
 
 The key sentence is 
 
 "It turns out that in this version of HPUX, the last argument to 
 getsockopt really has to be an int pointer, EVEN THOUGH it appears that the 
 function prototype is a socklen_t pointer.  Merely  changing the type of 'k' 
(in
 tnftp code this would be snlen) ... will solve this problem"
 
 The advice works on HP-UX 11.11 as well as I tested it a while ago.
 The connect() is affected too.
 
 Of course simply changing the variable type breaks potability of the code
 because other systems still expect socklen_t pointer :(
 
 At least main.c and util.c need tweaking