Re: pkg/44244 (crawl does not compile using GNU/Linux (pkgsrc 20010Q3))

[Ruben Gonzalez Arnau <rga%sdf.lonestar.org@localhost>]

The following reply was made to PR pkg/44244; it has been noted by GNATS.

From: Ruben Gonzalez Arnau <rga%sdf.lonestar.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/44244 (crawl does not compile using GNU/Linux  (pkgsrc
 20010Q3))
Date: Wed, 29 Dec 2010 07:25:14 +0100

 On Wed, Dec 29, 2010 at 05:10:06AM +0000, David Holland wrote:
 > The following reply was made to PR pkg/44244; it has been noted by GNATS.
 > 
 > From: David Holland <dholland-pbugs%netbsd.org@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: 
 > Subject: Re: pkg/44244 (crawl does not compile using GNU/Linux  (pkgsrc
 >  20010Q3))
 > Date: Wed, 29 Dec 2010 05:05:29 +0000
 > 
 >  On Wed, Dec 29, 2010 at 04:30:05AM +0000, Ruben Gonzalez Arnau wrote:
 >   >  vim workdir/pkgsrc/www/crawl/work/crawl-0.4/dns.c
 >   >  
 >   >  Line 42,
 >   >  
 >   >  +#ifdef EAI_NODATA
 >   >          if (res != EAI_NODATA)
 >   >                  return (-1);
 >   >  +#endif
 >  
 >  That's not the right fix -- at a minimum it ought to be
 >  
 >    +#ifdef EAI_NODATA
 >            if (res != EAI_NODATA)
 >                    return (-1);
 >    +else
 >    +       return (-1);
 >    +#endif
 >  
 >  but I don't think that's right either; EAI_NODATA ought to be defined.
 >  Does
 >  
 >     % find /usr/include -name '*.h' -print | xargs grep EAI_NODATA
 >  
 >  print anything?
 >  
 >  Also, when you compile, does anything like -D_POSIX_SOURCE or
 >  -D_GNU_SOURCE or similar appear on the compilation lines? It doesn't
 >  for me, but the most likely cause of this problem, especially on
 >  Linux, is that glibc is hiding the EAI_* definitions because it thinks
 >  it's been asked to be strictly compliant with some outdated standard.
 >  
 >  -- 
 >  David A. Holland
 >  dholland%netbsd.org@localhost
 >  
 
 Hello,
 
 I don't get -D_GNU_SOURCE or D_POSIX_SOURCE too.
 
 That's my output:
 
 $ find /usr/include -name '*.h' -print | xargs grep EAI_NODATA
 /usr/include/netdb.h:#  define EAI_NODATA         -5    /* No address
 associated with NAME.  */
 
 /usr/include/netdb.h
 ---
 # ifdef __USE_GNU
 #  define EAI_NODATA      -5    /* No address associated with NAME.  */
 #  define EAI_ADDRFAMILY  -9    /* Address family for NAME not
 #  supported.  */
 #  define EAI_INPROGRESS  -100  /* Processing request in progress.  */
 #  define EAI_CANCELED    -101  /* Request canceled.  */
 #  define EAI_NOTCANCELED -102  /* Request not canceled.  */
 #  define EAI_ALLDONE     -103  /* All requests done.  */
 #  define EAI_INTR        -104  /* Interrupted by a signal.  */
 #  define EAI_IDN_ENCODE  -105  /* IDN encoding failed.  */
 # endif
 
 Well, maybe it's good idea to check both #ifdef EAI_NODATA and #ifdef 
EAI_NONAME That's an idea only.
 
 -- 
 rga%sdf.lonestar.org@localhost