Re: pkg/44425: devel/lua-alt-getopt install problem

[Aleksey Cheusov <cheusov%tut.by@localhost>]

The following reply was made to PR pkg/44425; it has been noted by GNATS.

From: Aleksey Cheusov <cheusov%tut.by@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/44425: devel/lua-alt-getopt install problem
Date: Thu, 20 Jan 2011 15:23:40 +0200

  >>How-To-Repeat:
 
 >      Build the package on a NIS client under an unprivileged
 >      account with the NetBSD src tree present.
 
  >>Fix:
 >      Similar to PR 44415, a workaround could be to let
 >      devel/lua-alt-getopt/Makefile handle installation via
 >      "do-install:" target.
 
 pkgsrc contains dozens of packages with USE_BSD_MAKEFILE set to YES.
 While implementing do-install is pretty easy for lua-alt-getopt,
 it's probably not the best idea to do the same for all
 packages based on bsd.prog.mk.
 
 It's probably better to pass variables like BINOWN, BINGRP, INSTALL etc.
 through make arguments (MAKEFLAGS) instead of environment (MAKE_ENV).
 In this case their values will not be overriden by your *.mk files.
 
 Does the workaround in the end of this email solve your problem?
 
 Another way (the best?) to fix the problem is to use ?= instead of =
 in your *.mk files for variables listed above and similar.
 
 Another hot/dirty fix could be
    MAKEFLAGS+= BINOWN=${BINOWN} BINGRP=${BINGRP}
 in devel/lua-alt-getopt/Makefile.
 
 Index: bsd.pkg.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.mk,v
 retrieving revision 1.1975
 diff -u -r1.1975 bsd.pkg.mk
 --- bsd.pkg.mk  3 Nov 2010 18:02:40 -0000       1.1975
 +++ bsd.pkg.mk  20 Jan 2011 13:04:33 -0000
 @@ -174,7 +174,8 @@
  
  # This variable can be added to MAKE_ENV to ease installation of
    packages
  # that use BSD-style Makefiles.
 -BSD_MAKE_ENV=  BINOWN=${BINOWN} BINGRP=${BINGRP}
 +MAKEFLAGS+=    BINOWN=${BINOWN} BINGRP=${BINGRP}
 +#BSD_MAKE_ENV= BINOWN=${BINOWN} BINGRP=${BINGRP}
  BSD_MAKE_ENV+= GAMEOWN=${GAMEOWN} GAMEGRP=${GAMEGRP}
  BSD_MAKE_ENV+= MANOWN=${MANOWN} MANGRP=${MANGRP}
  BSD_MAKE_ENV+= SHAREOWN=${SHAREOWN} SHAREGRP=${SHAREGRP}
 
 -- 
 Best regards, Aleksey Cheusov.