pkg/44710: tnftp build problem on Linux

[gregoire.sutre%gmail.com@localhost]

>Number:         44710
>Category:       pkg
>Synopsis:       tnftp build problem on Linux
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 12 00:30:01 +0000 2011
>Originator:     Gregoire Sutre
>Release:        n/a
>Organization:
>Environment:
Linux tahoe 2.6.32-5-amd64 #1 SMP Wed Jan 12 03:40:32 UTC 2011 x86_64 GNU/Linux

>Description:
Building net/tnftp on my Debian GNU/Linux box fails if native socks libraries 
are installed.  After uninstalling all socks related software, the build 
problem disappears.  I guess that the configure script detects the presence of 
native socks libraries by default.

The attached patch fixes the problem, by explicitly adding --without-socks when 
the option `socks5' is disabled.

>How-To-Repeat:
(This is on a Debian GNU/Linux box.)

Install (with aptitude) the Debian package `libsocks4'.  Install and bootstrap 
pkgsrc as explained in the Pkgsrc Guide, and then try to install net/tnftp.  
Observe that it fails with:

gcc -Wno-error -Wno-format -fno-builtin -I/usr/include -L../libedit -L/usr/lib 
-Wl,-R/usr/lib -Wl,-R/home/sutre/pkg/lib -L../libnetbsd -o ftp cmds.o cmdtab.o 
complete.o domacro.o fetch.o ftp.o main.o progressbar.o ruserpass.o util.o 
-ledit -lsocks -ltermcap  -lnetbsd
cmds.o: In function `mintr':
cmds.c:(.text+0x142c): undefined reference to `Rwrite'
fetch.o: In function `fetch_url':
fetch.c:(.text+0x1a1f): undefined reference to `Rgetaddrinfo'
fetch.o: In function `aborthttp':
fetch.c:(.text+0x398b): undefined reference to `Rwrite'
ftp.o: In function `hookup':
ftp.c:(.text+0xbf): undefined reference to `Rgetaddrinfo'
ftp.o: In function `cmdabort':
ftp.c:(.text+0x5d1): undefined reference to `Rwrite'
ftp.o: In function `cmdtimeout':
ftp.c:(.text+0x653): undefined reference to `Rwrite'
ftp.o: In function `abortxfer':
ftp.c:(.text+0x11a1): undefined reference to `Rwrite'
ftp.o: In function `copy_bytes':
ftp.c:(.text+0x1275): undefined reference to `Rread'
ftp.c:(.text+0x12c4): undefined reference to `Rwrite'
ftp.o: In function `abortpt':
ftp.c:(.text+0x41e2): undefined reference to `Rwrite'
ftp.o: In function `abort_squared':
ftp.c:(.text+0x4a4b): undefined reference to `Rwrite'
ftp.o: In function `abort_remote':
ftp.c:(.text+0x4af9): undefined reference to `Rsend'
ftp.c:(.text+0x4bd6): undefined reference to `Rread'
main.o: In function `main':
main.c:(.text+0xa4c): undefined reference to `Rgetaddrinfo'
progressbar.o: In function `progressmeter':
progressbar.c:(.text+0x1f2): undefined reference to `Rwrite'
progressbar.c:(.text+0x927): undefined reference to `Rwrite'
progressbar.o: In function `ptransfer':
progressbar.c:(.text+0x100f): undefined reference to `Rwrite'
progressbar.o: In function `psummary':
progressbar.c:(.text+0x106c): undefined reference to `Rwrite'
util.o: In function `intr':
util.c:(.text+0x788): undefined reference to `Rwrite'
../libedit/libedit.a(read.o): In function `read_preread':
read.c:(.text+0x1e5): undefined reference to `Rread'
../libedit/libedit.a(read.o): In function `read_char':
read.c:(.text+0x439): undefined reference to `Rread'
../libedit/libedit.a(vi.o): In function `vi_histedit':
vi.c:(.text+0x14ee): undefined reference to `Rwrite'
vi.c:(.text+0x1507): undefined reference to `Rwrite'
vi.c:(.text+0x15c8): undefined reference to `Rread'
collect2: ld returned 1 exit status
*** Error code 1

Stop.
bmake: stopped in /home/sutre/pkgsrc/net/tnftp/work/tnftp-20070806/src
*** Error code 1

Stop.
bmake: stopped in /home/sutre/pkgsrc/net/tnftp/work/tnftp-20070806
*** Error code 1

Stop.
bmake: stopped in /home/sutre/pkgsrc/net/tnftp
*** Error code 1

Stop.
bmake: stopped in /home/sutre/pkgsrc/net/tnftp

>Fix:
Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/net/tnftp/options.mk,v
retrieving revision 1.4
diff -u -r1.4 options.mk
--- options.mk  9 Aug 2008 22:03:52 -0000       1.4
+++ options.mk  12 Mar 2011 00:24:10 -0000
@@ -11,6 +11,8 @@
 .if !empty(PKG_OPTIONS:Msocks5)
 CONFIGURE_ARGS+=       --with-socks
 .include "../../net/socks5/buildlink3.mk"
+.else
+CONFIGURE_ARGS+=       --without-socks
 .endif
 
 .if !empty(PKG_OPTIONS:Minet6)