Re: pkg/45562 (print/xpdf does not compile (when using lesstif))

[Thomas Klausner <wiz%NetBSD.org@localhost>]

The following reply was made to PR pkg/45562; it has been noted by GNATS.

From: Thomas Klausner <wiz%NetBSD.org@localhost>
To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
Cc: 
Subject: Re: pkg/45562 (print/xpdf does not compile (when using lesstif))
Date: Fri, 4 Nov 2011 11:41:56 +0100

 On Fri, Nov 04, 2011 at 11:38:12AM +0100, Jörn Clausen wrote:
 > On 11/04/11 11:18 AM, wiz%NetBSD.org@localhost wrote:
 > >Do you have patch suggestions? Otherwise we could just remove the option ;)
 > 
 > You mean remove lesstif from pkgsrc?
 
 No, the lesstif option from xpdf.
 
 > Just to prevent such drastic measures:
 > 
 > --- xpdf/XPDFViewer.cc.orig     2011-08-15 21:08:53.000000000 +0000
 > +++ xpdf/XPDFViewer.cc
 > @@ -1803,7 +1803,7 @@ void XPDFViewer::initToolbar(Widget pare
 >    menuPane = XmCreatePulldownMenu(toolBar, "zoomMenuPane", args, n);
 >    for (i = 0; i < nZoomMenuItems; ++i) {
 >      n = 0;
 > -    s = XmStringCreateLocalized(zoomMenuInfo[i].label);
 > +    s = XmStringCreateLocalized((char *)zoomMenuInfo[i].label);
 >      XtSetArg(args[n], XmNlabelString, s); ++n;
 >      XtSetArg(args[n], XmNuserData, (XtPointer)i); ++n;
 >      sprintf(buf, "zoom%d", i);
 > 
 > The same problem was fixed a few lines above in the top half of an
 > #if/#else block, but obviously missed on the other side. I'll report
 > it upstream.
 
 Great, thanks!
  Thomas