pkg/45614: devel/xulrunner needs build dep on archivers/unzip (NetBSD 5.0) (+FIX)

[kre%munnari.OZ.AU@localhost]

>Number:         45614
>Category:       pkg
>Synopsis:       devel/xulrunner needs build dep on archivers/unzip (NetBSD 
>5.0) (+FIX)
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Nov 14 12:00:01 +0000 2011
>Originator:     Robert Elz
>Release:        NetBSD 5.0  (pkgsrc current 2011-11-14)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 5.1 NetBSD 5.1 (JADE-1.12-20101117) #5: Wed 
Nov 17 05:30:55 ICT 2010 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/5.1/kernels/i386/JADE i386
Architecture: i386
Machine: i386
>Description:
        After the recent upgrade to 8.0 xulrunner (and firefox, seamonkey,
        and probably more I didn't get to) need unzip to be installed
        in order to configure.   By default, it isn't - mozilla-common.mk has
        a dependency on archivers/zip but that only installs the zip
        command, not unzip, archivers/unzip is needed for the latter.

>How-To-Repeat:
        Attempt to build devel/xulrunner (or www/firefox or www/seamonkey)
        on a bare-bones system (with just NetBSD, and required dependencies
        installed, and nothing else).

        I use pkg_comp with NetBSD 5.0 (and libkver, X11_TYPE=native,
        USE_DESTDIR=no but none of that is relevant here) installed, and
        start each package build in an empty (almost empty - as in almost
        no packages added) sandbox.

        In that environment, I see ...

        [.....]
=> Modifying GNU configure scripts to avoid --recheck
=> Replacing config-guess with pkgsrc versions
=> Replacing config-sub with pkgsrc versions
=> Replacing install-sh with pkgsrc version
=> Adding run-time search paths to pkg-config files.
INFO: [subst.mk:pkgconfig] Nothing changed in 
./xulrunner/installer/mozilla-gtkmozembed-embedding.pc.in.
INFO: [subst.mk:pkgconfig] Nothing changed in 
./xulrunner/installer/mozilla-gtkmozembed.pc.in.
INFO: [subst.mk:pkgconfig] Nothing changed in 
./xulrunner/installer/mozilla-plugin.pc.in.
=> Checking for portability problems in extracted files
creating cache ./config.cache
checking host system type... i386--netbsdelf
checking target system type... i386--netbsdelf
checking build system type... i386--netbsdelf
checking for mawk... /usr/bin/awk
checking for /usr/pkg/bin/perl... /usr/pkg/bin/perl
        [.....]
checking for minimum required perl version >= 5.006... 5.014002
checking for full perl installation... yes
checking for /usr/pkg/bin/python2.6... /usr/pkg/bin/python2.6
checking for doxygen... :
checking for autoconf... 
/pkg_comp/obj/pkgsrc/devel/xulrunner/5/.tools/bin/autoconf
checking for unzip... no
configure: error: unzip not found in $PATH
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/devel/xulrunner
*** Error code 1

Stop.

>Fix:
        Applying the following patch fixed it for me (for xulrunner, and
        firefox, which have now finished building, seamonkey is still
        compiling as I write this, but is beyond its config step).

        I have no idea if archivers/zip is still needed or not (SEP).

        I doubt that unzip 6.0 is actually needed, an earlier version
        would probably do, but unzip 6.0 is what we have, and I have no
        easy way to test older ones for this use, so ...

Index: mozilla-common.mk
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/devel/xulrunner/mozilla-common.mk,v
retrieving revision 1.26
diff -u -r1.26 mozilla-common.mk
--- mozilla-common.mk   19 Aug 2011 14:31:10 -0000      1.26
+++ mozilla-common.mk   14 Nov 2011 08:44:51 -0000
@@ -13,6 +13,7 @@
 UNLIMIT_RESOURCES+=    datasize
 
 BUILD_DEPENDS+=                zip>=2.3:../../archivers/zip
+BUILD_DEPENDS+=                unzip>=6.0:../../archivers/unzip
 
 PKG_DESTDIR_SUPPORT=   user-destdir
 CHECK_PORTABILITY_SKIP+=${MOZILLA_DIR}security/nss/tests/libpkix/libpkix.sh