Re: pkg/44577 openssl builtin detection, getting closer

["OBATA Akio" <obache%netbsd.org@localhost>]

The following reply was made to PR pkg/44577; it has been noted by GNATS.

From: "OBATA Akio" <obache%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/44577 openssl builtin detection, getting closer
Date: Wed, 16 Nov 2011 23:03:19 +0900

 On Wed, 16 Nov 2011 22:20:04 +0900, John Marino <netbsd%marino.st@localhost> 
wrote:
 
 >  The variable BUILTIN_PKG.openssl is cached, but BUILTIN_VERSION.openssl
 >  is not.
 > I would love to hear somebody spin this as a feature and not a
 >  straight-up bug.  Executing individual make targets is a legitimate user
 >  action.
 > Now that the anomaly is understood well, can we discuss how to fix this now?
 
 BUILTIN_VERSION.openssl must be added to MAKEVARS.
 How about following patch?
 
 Index: security/openssl/builtin.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/security/openssl/builtin.mk,v
 retrieving revision 1.30
 diff -u -r1.30 builtin.mk
 --- security/openssl/builtin.mk 4 Oct 2011 14:15:35 -0000       1.30
 +++ security/openssl/builtin.mk 16 Nov 2011 14:02:16 -0000
 @@ -104,6 +104,7 @@
   BUILTIN_PKG.openssl=   openssl-${BUILTIN_VERSION.openssl}
   .endif
   MAKEVARS+=     BUILTIN_PKG.openssl
 +MAKEVARS+=     BUILTIN_VERSION.openssl
 
   .if !defined(BUILTIN_OPENSSL_HAS_THREADS) && \
       !empty(IS_BUILTIN.openssl:M[yY][eE][sS]) && \
 
 
 -- 
 OBATA Akio / obache%NetBSD.org@localhost