pkg/45825: net/vpnc does link against pkgsrc's openssl if PREFER.openssl=pkgsrc is given

[kretschm%cs.uni-bonn.de@localhost]

>Number:         45825
>Category:       pkg
>Synopsis:       net/vpnc does link against pkgsrc's openssl if 
>PREFER.openssl=pkgsrc is given
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 12 11:45:00 +0000 2012
>Originator:     Matthias Kretschmer
>Release:        NetBSD 5.1_STABLE
>Organization:
>Environment:
NetBSD cat.cs.uni-bonn.de 5.1_STABLE NetBSD 5.1_STABLE (CAT) #1: Fri Apr  8 
09:38:30 CEST 2011  
root@fourier.hangelar.local:/home/src/sys/arch/i386/compile/obj/CAT i386
>Description:
net/vpnc does link against pkgsrc's openssl if PREFER.openssl=pkgsrc is given.

See (PREFER.openssl=pkgsrc was set in mk.conf):
# ldd /usr/pkg/sbin/vpnc
/usr/pkg/sbin/vpnc:
        -lgcrypt.11 => /usr/pkg/lib/libgcrypt.so.11
        -lgpg-error.0 => /usr/pkg/lib/libgpg-error.so.0
        -lintl.0 => /usr/lib/libintl.so.0
        -lc.12 => /usr/lib/libc.so.12
        -lcrypto.4 => /usr/lib/libcrypto.so.4
        -lcrypt.0 => /lib/libcrypt.so.0
>How-To-Repeat:
Just compile net/vpnc with PREFER.openssl=pkgsrc.
>Fix:
When choosing openssl option in net/vpnc there is a missing include of 
security/openssl/buildlink3.mk.  The following patch fixes that.

Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/net/vpnc/options.mk,v
retrieving revision 1.2
diff -u -r1.2 options.mk
--- options.mk  4 Feb 2009 21:51:27 -0000       1.2
+++ options.mk  12 Jan 2012 11:33:20 -0000
@@ -7,6 +7,7 @@
 .include "../../mk/bsd.prefs.mk"
 .include "../../mk/bsd.options.mk"
 .if !empty(PKG_OPTIONS:Mopenssl)
+.include "../../security/openssl/buildlink3.mk"
 SUBST_CLASSES+=                openssl
 SUBST_MESSAGE.openssl= adding openssl option
 SUBST_STAGE.openssl=   post-patch