pkg/45839: multimedia/x264-devel fails to build on NetBSD/adm64/5.99.59

[aran%100acres.us@localhost]

>Number:         45839
>Category:       pkg
>Synopsis:       multimedia/x264-devel fails to build on NetBSD/adm64/5.99.59
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 15 18:10:01 +0000 2012
>Originator:     Aran Clauson
>Release:        5.99.59
>Organization:
>Environment:
NetBSD sanders 5.99.59 NetBSD 5.99.59 (SANDERS) #1: Mon Jan  9 21:19:08 PST 
2012  aran@sanders:/home/NetBSD/obj/sys/arch/amd64/compile/SANDERS amd64
>Description:
Building fails with

ld: common/x86/.libs/cabac-a.o: relocation R_X86_64_PC32 against symbol 
`x264_cabac_range_lps' can not be used when making a shared object; recompile 
with -fPIC
ld: final link failed: Bad value
gmake: *** [libx264.la] Error 1

>How-To-Repeat:
Try to build on an amd64 current system.
>Fix:
The problem seems to be that asm files are included when they should be 
ignored.  There is a CONFIGURE_ARGS+=--disable-asm that looks like it should be 
included for this build.  It is not because of the conditional expression:

.  if ${OPSYS} == "SunOS" || (${OPSYS} == "NetBSD" && \
        (!empty(OS_VERSION:M[1-5].*) && empty(OS_VERSION:M5.99.*))) || \
      ${OPSYS} == "Darwin"
CONFIGURE_ARGS+=        --disable-asm
.  else

I suspect that "&& empty(OS_VERSION:M5.99.*)" should be removed.  I did that 
and the build succeeded. However, I do not know how this might impact others.