pkg/45949: bash build on IRIX fails due to missing -c99 flag in builtins

[duck+important%shangtai.net@localhost]

>Number:         45949
>Category:       pkg
>Synopsis:       bash build on IRIX fails due to missing -c99 flag in builtins
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 08 15:35:00 +0000 2012
>Originator:     duck+important%shangtai.net@localhost
>Release:        pkgsrc-2011Q3
>Organization:
>Environment:
System: IRIX64 halo 6.5 6.5.29m 01090133 IP30
Architecture: mipseb
Machine: IP30
>Description:
Building bash fails because the Makefile rule for compiling mkbuiltins.o does
not use CFLAGS but a long meandering chain of other variables that somehow do
not pull in CFLAGS. This makes us lose the -c99 flag which is required for using
C99 standard headers with MIPSPro.

>How-To-Repeat:
Attempt to build bash on IRIX while for exampel testing a build of netpbm.
>Fix:
Make a new patch, like this. It takes care of the missing compiler flag. There
is a potential here for other systems to fail because of extraenous compiler
flags (I don't know, maybe they actually had a reason for not making it use
CFLAGS?)

I tested this and it works on IRIX, NetBSD 5.1/alpha, NetBSD 4.0/i386

--- builtins/Makefile.in.orig   Tue Dec 21 15:37:18 2010
+++ builtins/Makefile.in        Wed Feb  8 16:49:52 2012
@@ -56,7 +56,7 @@

 PROFILE_FLAGS = @PROFILE_FLAGS@
 CFLAGS = @CFLAGS@
-CFLAGS_FOR_BUILD = @CFLAGS_FOR_BUILD@ @CROSS_COMPILE@
+CFLAGS_FOR_BUILD = @CFLAGS@ @CFLAGS_FOR_BUILD@ @CROSS_COMPILE@
 CPPFLAGS = @CPPFLAGS@
 CPPFLAGS_FOR_BUILD = @CPPFLAGS_FOR_BUILD@
 LOCAL_CFLAGS = @LOCAL_CFLAGS@ ${DEBUG}