pkg/46112: [Linux] graphics/graphviz fails to build if native tcl is on the path

[slitvinov%gmail.com@localhost]

>Number:         46112
>Category:       pkg
>Synopsis:       [Linux] graphics/graphviz fails to build if native tcl is on 
>the path
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 28 20:45:00 +0000 2012
>Originator:     Litvinov Sergey
>Release:        Linux
>Organization:
>Environment:
Linux vital303-desktop 3.0.0-15-generic #26-Ubuntu SMP Fri Jan 20 15:59:53 UTC 
2012 i686 athlon i386 GNU/Linux
>Description:
graphics/graphviz is confused if native tcl is on the path

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -DUSE_TCL_STUBS 
-DUSE_TK_STUBS -I/usr/include/tcl8.5 -I/usr/include/tcl8.5/generic 
-DNO_POSTSCRIPT_ALIAS=1 -I/media/sdb2/src/pkgsrc/gr\
aphics/graphviz/work/.buildlink/include 
-I/media/sdb2/src/pkgsrc/graphics/graphviz/work/.buildlink/include/freetype2 
-O2 -Wno-error -Wno-unknown-pragmas -Wstrict-prototypes -Wpointer-ar\
ith -Wall -ffast-math -MT tkStubLib.lo -MD -MP -MF .deps/tkStubLib.Tpo -c 
tkStubLib.c  -fPIC -DPIC -o .libs/tkStubLib.o
In file included from tkStubLib.c:18:0:
/media/sdb2/src/pkgsrc/graphics/graphviz/work/.buildlink/include/tk.h:23:3: 
error: #error Tk 8.4 must be compiled with tcl.h from Tcl 8.4
*** Error code 1

in configure.ac the first attempt to find tcl is like this

if test "x$TCLSH" = "x"; then
  AC_PATH_PROGS(TCLSH,[tclsh8.6 tclsh8.5 tclsh8.4 tclsh8.3 tclsh])
#  if test "x$TCLSH" = "x"; then
#    AC_MSG_ERROR([Unable to find a tclsh. Tclsh is a required program for 
building graphviz, independent of wether tcl-based graphviz products are built])
#    use_tcl="No (tclsh unavailable)"
#  fi
fi

>How-To-Repeat:
Run bmake in
graphics/graphviz
with native tcl on the path
>Fix:
Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/graphviz/options.mk,v
retrieving revision 1.12
diff -u -a -r1.12 options.mk
--- options.mk  29 Nov 2011 17:55:07 -0000      1.12
+++ options.mk  28 Feb 2012 20:35:38 -0000
@@ -130,8 +130,8 @@
 .if !empty(PKG_OPTIONS:Mtcl)
 USING_SWIG=    yes
 .include "../../x11/tk/buildlink3.mk"
-CONFIGURE_ENV+=                TCLCONFIG=${TCLCONFIG_SH:Q}
-CONFIGURE_ENV+=                TKCONFIG=${TKCONFIG_SH:Q}
+CONFIGURE_ARGS+=       --with-wish=${PREFIX}/bin/wish
+CONFIGURE_ARGS+=       --with-tclsh=${PREFIX}/bin/tclsh
 PLIST.tcl=             yes
 .else
 CONFIGURE_ARGS+=       --disable-tcl