Re: pkg/46190: pkgsrc-2011Q4 - misc/rlwrap - Segfaults on amd64 - odd gdb results

[Matthew Mondor <mm_lists%pulsar-zone.net@localhost>]

The following reply was made to PR pkg/46190; it has been noted by GNATS.

From: Matthew Mondor <mm_lists%pulsar-zone.net@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/46190: pkgsrc-2011Q4 - misc/rlwrap - Segfaults on amd64 -
 odd gdb results
Date: Tue, 1 May 2012 07:26:50 -0400

 --MP_/Rehqxbvrph4HXLP7j30kUbv
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 
 These make rlwrap work for me on NetBSD/amd64.  I'm not sure that the
 patch that adds the __NetBSD__ check is optimal, but it seems that
 configure.in changes would be required to properly detect termcap
 presence otherwise...
 
 -- 
 Matt
 
 --MP_/Rehqxbvrph4HXLP7j30kUbv
 Content-Type: text/plain
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=rlwrap-diff.txt
 
 Index: distinfo
 ===================================================================
 RCS file: /data/rsync/netbsd-cvs/pkgsrc/misc/rlwrap/distinfo,v
 retrieving revision 1.2
 diff -u -r1.2 distinfo
 --- distinfo   9 Jan 2008 13:40:38 -0000       1.2
 +++ distinfo   1 May 2012 11:20:17 -0000
 @@ -3,3 +3,5 @@
  SHA1 (rlwrap-0.30.tar.gz) = 26f3a6348710fee5e87f5274ddc29af8eaaf65d2
  RMD160 (rlwrap-0.30.tar.gz) = 23f19b9e98f61183fe719ee7a62db9d8ee2cf602
  Size (rlwrap-0.30.tar.gz) = 184037 bytes
 +SHA1 (patch-aa) = d4590dcb9b73b2ee778896eb8f6f36f8ef26a641
 +SHA1 (patch-ab) = 565021b2a1372c3a8ad77161c56ce94702097cb6
 
 --MP_/Rehqxbvrph4HXLP7j30kUbv
 Content-Type: text/plain
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=patch-aa
 
 If openpty(3) is in libutil, include util.h to avoid broken code on amd64
 
 --- src/ptytty.c.orig  2007-09-16 06:49:21.000000000 -0400
 +++ src/ptytty.c       2012-05-01 07:15:34.000000000 -0400
 @@ -38,6 +38,9 @@
  #ifdef HAVE_FCNTL_H
  # include <fcntl.h>
  #endif
 +#ifdef HAVE_LIBUTIL
 +# include <util.h>
 +#endif
  #ifdef HAVE_SYS_IOCTL_H
  # include <sys/ioctl.h>
  #endif
 
 --MP_/Rehqxbvrph4HXLP7j30kUbv
 Content-Type: text/plain
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=patch-ab
 
 I'm not sure this patch is optimal, configure script changes would
 be required to make it better.  If on NetBSD, include termcap.h to
 provide the required prototypes and avoid generating broken code
 on amd64.
 
 --- src/rlwrap.h.orig  2007-12-27 06:17:58.000000000 -0500
 +++ src/rlwrap.h       2012-05-01 07:10:39.000000000 -0400
 @@ -105,6 +105,10 @@ char *strchr(), *strrchr();
  #  include <util.h>
  #endif
  
 +#ifdef __NetBSD__
 +# include <termcap.h>
 +#endif
 +
  
  
  
 
 --MP_/Rehqxbvrph4HXLP7j30kUbv--