pkg/46473: pkgtools/gnome-packagekit doesn't build given deprecated glib call

[noud4%home.nl@localhost]

>Number:         46473
>Category:       pkg
>Synopsis:       pkgtools/gnome-packagekit doesn't build given deprecated glib 
>call
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue May 22 14:05:00 +0000 2012
>Originator:     Noud de Brouwer
>Release:        6.99.4
>Organization:
-none-
>Environment:
NetBSD 10.0.2.17 6.99.4 NetBSD 6.99.4 (MONOLITHIC) #0: Wed Apr 18 09:37:46 UTC 
2012  mickey55@10.0.2.17:/obj-src/sys/arch/i386/compile/MONOLITHIC i386
>Description:
pkgtools/gnome-packagekit doesn't build given deprecated glib call.

gpk-application.c: In function 'gpk_application_details_cb':

gpk-application.c:1038:3: error: 'g_format_size_for_display' is deprecated 
(declared at 
/obj/pkgtools/gnome-packagekit/work/.buildlink/include/glib/glib-2.0/glib/gutils.h:215):
 Use 'g_format_size' instead


>How-To-Repeat:
cd pkgtools/gnome-packagekit && make
>Fix:
2 options, CFLAGS in Makefile or an extra patches/patch-src_gpk-application.c 
(the later prefered).

--- Makefile.orig       2012-05-22 16:14:04.000000000 +0000
+++ Makefile    2012-05-22 16:14:51.000000000 +0000
@@ -16,6 +16,7 @@
 USE_LIBTOOL=   yes
 USE_TOOLS+=    pkg-config gmake intltool perl msgfmt
 USE_PKGLOCALEDIR= yes
+CFLAGS+=       -Wno-error=deprecated-declarations
 
 GCONF_SCHEMAS+=        gnome-packagekit.schemas
 

patches/patch-src_gpk-application.c:

--- src/gpk-application.c.orig  2012-05-22 13:50:17.000000000 +0000
+++ src/gpk-application.c       2012-05-22 13:50:38.000000000 +0000
@@ -1035,7 +1035,7 @@
        /* if non-zero, set the size */
        if (details->size > 0) {
                /* set the size */
-               value = g_format_size_for_display (details->size);
+               value = g_format_size (details->size);
                if (egg_strequal (details->id->data, "meta"))
                        /* TRANSLATORS: the size of the meta package */
                        gpk_application_add_detail_item (application, 
_("Size"), value, NULL);