Re: pkg/46511: math/gnumeric and gnumeric110 miss psiconv dependency, so do not build

[Noud de Brouwer <noud4%home.nl@localhost>]

The following reply was made to PR pkg/46511; it has been noted by GNATS.

From: Noud de Brouwer <noud4%home.nl@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/46511: math/gnumeric and gnumeric110 miss psiconv
 dependency, so do not build
Date: Fri, 01 Jun 2012 13:54:25 +0000

 On Fri, 2012-06-01 at 10:55 +0000, Thomas Klausner wrote:
 >  I guess they only don't build when you have psiconv installed. Could
 >  you make it optional or do you think it's a good standard dependency?
 
 Spot-on right, it's an opt-out configuration feature
 and should never be a standard dependency.
 This has to be an option indeed,
 so new options.mk and patch to Makefile.
 
 options.mk:
 
 # $NetBSD$
 
 PKG_OPTIONS_VAR=       PKG_OPTIONS.gnumeric
 PKG_SUPPORTED_OPTIONS= psiconv
 
 .include "../../mk/bsd.options.mk"
 
 .if !empty(PKG_OPTIONS:Mpsiconv)
 .include "../../converters/psiconv/buildlink3.mk"
 .else
 CONFIGURE_ARGS+=       --without-psiconv
 .endif
 
 Makefile patch:
 
 --- Makefile.orig      2012-06-01 10:52:17.000000000 +0000
 +++ Makefile   2012-06-01 16:00:16.000000000 +0000
 @@ -28,6 +28,8 @@
  .include "../../lang/python/application.mk"
  .include "../../devel/py-gobject/buildlink3.mk"
  
 +.include "options.mk"
 +
  # XXX: that version's not in pkgsrc yet
  #BUILDLINK_API_DEPENDS.libgda+=       libgda>=3.1.1
  #.include "../../databases/libgda/buildlink3.mk"
 
 Same goes for gnumeric110.
 
 (what did happen was i did build gnumeric,
 then all in converters, then failed update gnumeric.)
 
 Noud