Re: pkg/46570: infelicities in pkglint

[Thomas Klausner <wiz%NetBSD.org@localhost>]

The following reply was made to PR pkg/46570; it has been noted by GNATS.

From: Thomas Klausner <wiz%NetBSD.org@localhost>
To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
Cc: 
Subject: Re: pkg/46570: infelicities in pkglint
Date: Mon, 9 Jul 2012 19:42:24 +0200

 I'll not comment further about the complaints about the language,
 because it is a well-written script in a language intended for
 handling text, and does it job well for single packages.
 
 On Sat, Jun 09, 2012 at 08:50:01PM +0000, David Holland wrote:
 > - It does not understand USE_GAMESGROUP or its accompanying
 > paraphernalia, and issues a bucket of spurious warnings instead of
 > guiding correct usage. I looked into fixing this at one point and was
 > stopped by the first two issues.
 
 I've just fixed these issues. USE_GAMESGROUP wasn't even documented in
 the guide, so I fixed that as welll.
 
 > - It has a system of permissions for make variable usage in various
 > contexts, which is fine, but when it warns about violations it reports
 > the permissions as single letters. The letters are not documented in
 > the man page. To find out what they mean, you need to UTSL (see points
 > 1 and 2) or notice the -e option. It should use words in the
 > diagnostics, especially since we encourage novice packagers to use
 > pkglint.
 
 I've added a reference to -e in the final output line if any problems
 were found, and documented the permissions in the man page.
 
 > - It will happily attempt to check gmake makefiles (which can appear
 > in a package's files/ directly) ... and then when it encounters gmake
 > syntax, which it doesn't understand, it doesn't even spew errors but
 > *aborts*.
 
 I don't see how this is a problem, since this is intended for checking
 pkgsrc Makefiles and only to be called from pkgsrc/category/program,
 where no GNU makefile should ever reside.
 
 > - If it encounters a file called Makefile.PL it expects it to be a
 > makefile (rather than a perl script) and *aborts* when it finds the
 > syntax confusing.
 
 I don't see how this is a problem, since this is intended for checking
 pkgsrc Makefiles and only to be called from pkgsrc/category/program,
 where no Perl Makefile.PL should ever reside.
 
 > - It doesn't understand the .-include "file" syntax and *aborts* upon
 > encountering it in a makefile.
 
 I don't see how this is a problem, since this is intended for checking
 pkgsrc Makefiles and only to be called from pkgsrc/category/program,
 where I didn't find any occurrence of ".-include" in the current
 pkgsrc tree, nor do I expect any to appear.ever reside.
 
 > - Currently when run in ruby18-base it somehow imagines that it should
 > be looking at ruby19-base's patches and spews about six screenfuls of
 > completely nonsensical errors.
 
 I can't reproduce this on ruby18-base nor ruby19-base, so I suspect
 this has been fixed in the meantime.
 
 > - It complains incorrectly about not being in -e mode if it encounters
 > a makefile recipe with a shell for loop, because of the semicolon in
 > the for loop syntax.
 
 Can you please give me an example package where I can reproduce this?
 
 Cheers,
  Thomas