pkg/46691: apache24 with suexec option doesn't install mod_suexec

[schmonz%netbsd.org@localhost]

>Number:         46691
>Category:       pkg
>Synopsis:       apache24 with suexec option doesn't install mod_suexec
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 11 15:35:00 +0000 2012
>Originator:     Amitai Schlair
>Release:        5.1.2
>Organization:
Schmonz Enterprises
>Environment:
NetBSD miracle-dirt 5.1.2 NetBSD 5.1.2 (PANIX-VC) #0: Wed Feb 22 08:30:42 EST 
2012  
root%juggler.panix.com@localhost:/devel/netbsd/5.1.2/src/sys/arch/i386/compile/PANIX-VC
 i386
>Description:
With pkgsrc-current (updated today), and option "suexec", www/apache24 installs 
the suexec binary, but does not install mod_suexec.so.

With the same option set, www/apache22 installs both. (That's what I'd been 
using until now.)
>How-To-Repeat:
Try upgrading from apache22 to apache24 while relying on suexec.
>Fix:
A quick guess that worked around the problem, whatever it is:

Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/www/apache24/PLIST,v
retrieving revision 1.5
diff -u -r1.5 PLIST
--- PLIST       18 Apr 2012 11:27:01 -0000      1.5
+++ PLIST       11 Jul 2012 15:28:21 -0000
@@ -160,6 +160,7 @@
 lib/httpd/mod_ssl.so
 lib/httpd/mod_status.so
 lib/httpd/mod_substitute.so
+${PLIST.suexec}lib/httpd/mod_suexec.so
 lib/httpd/mod_unique_id.so
 lib/httpd/mod_unixd.so
 lib/httpd/mod_userdir.so
Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/www/apache24/options.mk,v
retrieving revision 1.3
diff -u -r1.3 options.mk
--- options.mk  15 Apr 2012 12:23:49 -0000      1.3
+++ options.mk  11 Jul 2012 15:28:21 -0000
@@ -47,11 +47,11 @@
        --with-suexec-docroot=${APACHE_SUEXEC_DOCROOT:Q}                \
        --with-suexec-logfile=${APACHE_SUEXEC_LOGFILE}
 
-.  if !empty(PKG_OPTIONS:Mapache-shared-modules)
+#.  if !empty(PKG_OPTIONS:Mapache-shared-modules)
 CONFIGURE_ARGS+=       --enable-modules="all suexec"
-.  else
+#.  else
 APACHE_MODULES+=       suexec
-.  endif
+#.  endif
 CONFIGURE_ARGS+=       ${APACHE_SUEXEC_CONFIGURE_ARGS:M--with-suexec-*}
 BUILD_DEFS+=           APACHE_SUEXEC_CONFIGURE_ARGS
 BUILD_TARGET=          all suexec