pkg/46777: sysutils/dbus does not compile on Solaris 10 with GCC 4

[joern.clausen%uni-bielefeld.de@localhost]

>Number:         46777
>Category:       pkg
>Synopsis:       sysutils/dbus does not compile on Solaris 10 with GCC 4
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 07 09:20:01 +0000 2012
>Originator:     Jörn Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
>Description:
Compilation of sysutils/dbus 1.6.4 on Solaris 10 with GCC 4.7.0 and native 
assembler and linker fails at various stages.
>How-To-Repeat:

>Fix:
The following changes are necessary to successfully build the package:

pkgsrc's Makefile:

--- Makefile    2012/08/07 08:51:02     1.1
+++ Makefile    2012/08/07 08:51:25
@@ -32,6 +32,7 @@
 #CONFIGURE_ARGS+=      --enable-embedded-tests
 
 #CFLAGS.NetBSD+=               -D_NETBSD_SOURCE
+CFLAGS.SunOS+= -std=c99 -D_XPG6
 
 CONFIGURE_ARGS_GROUPS= enable disable with without


new patches:

--- dbus/dbus-sysdeps-util-unix.c.orig  2012-06-28 14:49:23.000000000 +0000
+++ dbus/dbus-sysdeps-util-unix.c
@@ -424,7 +424,7 @@ _dbus_request_file_descriptor_limit (uns
 void
 _dbus_init_system_log (void)
 {
-#ifdef HAVE_DECL_LOG_PERROR
+#if HAVE_DECL_LOG_PERROR
   openlog ("dbus", LOG_PID | LOG_PERROR, LOG_DAEMON);
 #else
   openlog ("dbus", LOG_PID, LOG_DAEMON);

--- dbus/sd-daemon.h.orig       2012-06-06 10:45:55.000000000 +0000
+++ dbus/sd-daemon.h
@@ -67,7 +67,7 @@ extern "C" {
   See sd-daemon(7) for more information.
 */
 
-#if __GNUC__ >= 4
+#if __GNUC__ >= 4 && !(__sun__)
 #define _sd_printf_attr_(a,b) __attribute__ ((format (printf, a, b)))
 #define _sd_hidden_ __attribute__ ((visibility("hidden")))
 #else


Finally, patch-ab needs to include

#include <alloca.h>

guarded by a suitable #if.