Re: pkg/47297: fonts/ttmkfdir2 fails to build with PKGSRC_COMPILER=clang

[Daniel Loffgren <miyokojiro%gmail.com@localhost>]

The following reply was made to PR pkg/47297; it has been noted by GNATS.

From: Daniel Loffgren <miyokojiro%gmail.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/47297: fonts/ttmkfdir2 fails to build with 
PKGSRC_COMPILER=clang
Date: Mon, 10 Dec 2012 17:10:00 -0800

 That does get them to build without needing explicit tags. However, =
 libtool-base is a dependency of lang/clang in pkgsrc, which creates a =
 sort of chicken and egg issue if you don't have clang to start with, and =
 do build it from source. Additionally, security/nettle already has CC =
 tags added to the libtool lines via pkgsrc patches, but not LD tags. I =
 could be overlooking something, but wouldn't it be better to just be =
 explicit in both cases, and not depend on a libtool that was built =
 with/after whatever compiler you may be using?
 
 On Dec 10, 2012, at 3:45 AM, Thomas Klausner <wiz%NetBSD.org@localhost> wrote:
 
 > The following reply was made to PR pkg/47297; it has been noted by =
 GNATS.
 >=20
 > From: Thomas Klausner <wiz%NetBSD.org@localhost>
 > To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
 > Cc:=20
 > Subject: Re: pkg/47297: fonts/ttmkfdir2 fails to build with
 > PKGSRC_COMPILER=3Dclang
 > Date: Mon, 10 Dec 2012 12:43:18 +0100
 >=20
 > For this and your other bug report on the same subject:
 > Can you please make sure you've compiled libtool with the same =
 settings?
 >=20
 > I.e. pkg_delete libtool*
 > cd /usr/pkgsrc/devel/libtool-base
 > make install
 > (with the same mk.conf you use for building packages)
 >=20
 > Thanks,
 >  Thomas
 >=20
 > On Sat, Dec 08, 2012 at 05:45:00AM +0000, miyokojiro%gmail.com@localhost 
 > wrote:
 >>> Number:         47297
 >>> Category:       pkg
 >>> Synopsis:       fonts/ttmkfdir2 fails to build with =
 PKGSRC_COMPILER=3Dclang
 >>> Confidential:   no
 >>> Severity:       non-critical
 >>> Priority:       low
 >>> Responsible:    pkg-manager
 >>> State:          open
 >>> Class:          sw-bug
 >>> Submitter-Id:   net
 >>> Arrival-Date:   Sat Dec 08 05:45:00 +0000 2012
 >>> Originator:     Daniel Loffgren
 >>> Release:        NetBSD 6.99.15 (HEAD as of Dec 6 2012)
 >>> Organization:
 >>> Environment:
 >> NetBSD Maki.local 6.99.15 NetBSD 6.99.15 (VMWARE) #6: Fri Dec  7 =
 15:21:43 UTC 2012  =
 kojiro@Maki.local:/usr/src/sys/arch/i386/compile/VMWARE i386
 >>> Description:
 >> libtool can't determine the intended behavior of clang since it's not =
 being called via gcc, g++, ld, etc., so it needs to be explicitly =
 specified. This problem could possibly arise with other compilers as =
 well, and there should be no harm in being explicit.
 >>=20
 >>> How-To-Repeat:
 >> Have clang
 >> Set PKGSRC_COMPILER=3Dclang
 >> Try to build fonts/ttmkfdir2
 >>> Fix:
 >> This diff (applied to patch-aa, not added separately to patches) adds =
 tags to hint functionality to libtool without changing the behavior of =
 the build.
 >>=20
 >> Index: patch-aa
 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 >> RCS file: /cvsroot/pkgsrc/fonts/ttmkfdir2/patches/patch-aa,v
 >> retrieving revision 1.3
 >> diff -r1.3 patch-aa
 >> 3c3
 >> < --- Makefile.orig Wed Nov  6 23:28:44 2002
 >> ---
 >>> --- Makefile.orig  2002-11-07 05:28:44.000000000 +0000
 >> 27c27
 >> < + libtool --mode=3Dcompile $(CXX) $(CPPFLAGS) $(CXXFLAGS) -o $@ -c =
 $^
 >> ---
 >>> +  libtool --tag=3DCC --mode=3Dcompile $(CXX) $(CPPFLAGS) =
 $(CXXFLAGS) -o $@ -c $^
 >> 30c30,31qi
 >> <   libtool --mode=3Dlink $(CXX) -o $@ $^ $(LDFLAGS)
 >> ---
 >>> -  libtool --mode=3Dlink $(CXX) -o $@ $^ $(LDFLAGS)
 >>> +  libtool --tag=3DLD --mode=3Dlink $(CXX) -o $@ $^ $(LDFLAGS)
 >>=20
 >=20