Re: PR/47420 CVS commit: pkgsrc/mail/milter-greylist

[Richard PALO <Richard.PALO%baou.fr@localhost>]

The following reply was made to PR pkg/47420; it has been noted by GNATS.

From: Richard PALO <Richard.PALO%baou.fr@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: PR/47420 CVS commit: pkgsrc/mail/milter-greylist
Date: Sun, 13 Jan 2013 11:46:24 +0100

 This is a multi-part message in MIME format.
 --------------070807000909090907030905
 Content-Type: text/plain; charset=windows-1252; format=flowed
 Content-Transfer-Encoding: 8bit
 
 Le 13/01/13 11:11, Matthias Scheler a écrit :
 > On Sun, Jan 13, 2013 at 06:10:12AM +0000, Richard PALO wrote:
 >>   The advantage of the following, I believe even on netbsd, is that the
 >>   user can set BDB_DEFAULT to anything required (db1 .. db5) on any 
 >> platform.
 >>
 >>     CONFIGURE_ARGS+=       --enable-drac --with-drac-db=${DRACD_DB}
 >>     +BDB_ACCEPTED=db1 db2 db3 db4 db5
 >
 > This line is superfluous.
 >
 >>     +.include "../../mk/bdb.buildlink3.mk"
 >>     +.if ${BDB_TYPE} != "db1"
 >>     +CPPFLAGS+=     -DUSE_DB185_EMULATION
 >>     +.endif
 >>     +LIBS+=${BDB_LIBS}
 >
 > But does that construct build under Solaris 11? The whole reason for the
 > special treatment of SunOS is that you earlier reported that the build
 > failed if "db1" was included in "BDB_ACCEPTED". If it works it is of
 > course preferrable.
 >
 > On a sidenote: the user would have to set "BDB185_DEFAULT", not 
 > "BDB_DEFAULT".
 >
 >      Kind regards
 >
 
 No, I said it wouldn't build if BDB_DEFAULT=db1 is set on the bmake line.
 
 On solaris, at least by default, there is no db1 builtin.
 
 Also, there is no pkgsrc/databases/db1 to build.  That is the only 
 reason db1 fails to build on solaris, which I can't really consider 
 critical as db2..db5 all provide backwards-compatibility with BDB185.
 
 My primary suggestion (perhaps obsession) is simplification of the use 
 case:  1. if db1 is present, use it, else
         2. use whichever db the user has by default (or db4 if not set)
            in DB185 compatibility mode.
 
 After looking again at bdb.buildlink3.mk, I would be quite happy with 
 the following, which seems to work *just fine* for me as well;-)
 
   CONFIGURE_ARGS+=       --enable-drac --with-drac-db=${DRACD_DB}
   +.include "../../mk/bdb.buildlink3.mk"
   +.if ${BDB_TYPE} != "db1"
   +CPPFLAGS+=     -DUSE_DB185_EMULATION
   +.endif
   +LIBS+=${BDB_LIBS}
 
 I believe we can bury this now if you are with me.
 
 -- 
 Richard PALO
 TNT PACA, dénomination commerciale de la société BAOU
 SAS au capital de 50.000 ? - RCS TOULON 441 322 385 - APE 4322B
 117, av Marcel Berre - ZI Camp Laurent - 83500 LA SEYNE SUR MER
 tél:04.94.94.39.94 fax:04.94.87.86.67 mailto:Richard.PALO%baou.fr@localhost
 » Avant d'imprimer, pensez aux conséquences environnementales «
 
 --------------070807000909090907030905
 Content-Type: text/x-vcard; charset=utf-8;
  name="Richard_PALO.vcf"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="Richard_PALO.vcf"
 
 begin:vcard
 fn:Richard PALO
 n:PALO;Richard
 org:SAS BAOU;TNT PACA
 adr:ZI Camp Laurent;;117, av Marcel Berre;LA SEYNE SUR MER;VAR;83500;FRANCE
 email;internet:richard.palo%baou.fr@localhost
 tel;work:+33 4 94 94 39 94
 tel;fax:+33 4 94 87 86 67
 x-mozilla-html:FALSE
 version:2.1
 end:vcard
 
 
 --------------070807000909090907030905--