pkg/47735: security/libgcrypt 1.5.1 DragonFly does not need patch-mpi_mpi-internal.h__

[davshao%gmail.com@localhost]

>Number:         47735
>Category:       pkg
>Synopsis:       security/libgcrypt 1.5.1 DragonFly does not need 
>patch-mpi_mpi-internal.h__
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 11 16:30:01 +0000 2013
>Originator:     David Shao
>Release:        DragonFly 3.5-DEVELOPMENT x86_64
>Organization:
>Environment:
DragonFly 3.5-DEVELOPMENT x86_64
>Description:
On DragonFly 3.5-DEVELOPMENT x86_64 using current pkgsrc master
commit be2d790cd26725778b6a7eea1a7486dd4df79e8b
Date:   Thu Apr 11 06:58:59 2013 -0700

with compilers
$ cc --version
cc 4.7.2 [DragonFly] Release/2012-09-20

$ c++ --version
c++ 4.7.2 [DragonFly] Release/2012-09-20

security/libgcrypt 1.5.1 fails to build:

configure: WARNING: unrecognized options: --with-libintl-prefix

        Libgcrypt v1.5.1 has been configured as follows:

        Revision:                  d2f2f90  (54002)
        Platform:                  DragonFly (x86_64-pc-dragonfly)
        Enabled cipher algorithms: arcfour blowfish cast5 des aes twofish 
serpent rfc2268 seed camellia
        Enabled digest algorithms: crc md4 md5 rmd160 sha1 sha256 sha512 tiger 
whirlpool
        Enabled pubkey algorithms: dsa elgamal rsa ecc
        Random number generator:   default
        Using linux capabilities:  no
        Try using Padlock crypto:  no
        Try using AES-NI crypto:   no
...
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I.. -I../src -fPIC 
-I/usr/pkgsrc/security/libgcrypt/work/.buildlink/include 
-I/usr/pkgsrc/security/libgcrypt/work/.buildlink/include/gettext -g -fPIC 
-fvisibility=hidden -Wall -MT mpi-add.lo -MD -MP -MF .deps/mpi-add.Tpo -c 
mpi-add.c  -fPIC -DPIC -o .libs/mpi-add.o
In file included from mpi-internal.h:274:0,
                 from mpi-add.c:31:
mpi-inline.h:128:7: warning: '_gcry_mpih_sub_1' is static but used in inline 
function '_gcry_mpih_sub' which is not static [enabled by default]
mpi-inline.h:82:7: warning: '_gcry_mpih_add_1' is static but used in inline 
function '_gcry_mpih_add' which is not static [enabled by default]
...
libtool: link: cc -shared  .libs/libgcrypt_la-visibility.o 
.libs/libgcrypt_la-misc.o .libs/libgcrypt_la-global.o .libs/libgcrypt_la-sexp.o 
.libs/libgcrypt_la-hwfeatures.o .libs/libgcrypt_la-stdmem.o 
.libs/libgcrypt_la-secmem.o .libs/libgcrypt_la-missing-string.o 
.libs/libgcrypt_la-module.o .libs/libgcrypt_la-fips.o 
.libs/libgcrypt_la-hmac256.o .libs/libgcrypt_la-ath.o  -Wl,--whole-archive 
../cipher/.libs/libcipher.a ../random/.libs/librandom.a ../mpi/.libs/libmpi.a 
../compat/.libs/libcompat.a -Wl,--no-whole-archive  -Wl,-rpath 
-Wl,/usr/pkgsrc/security/libgcrypt/work/.buildlink/lib -Wl,-rpath 
-Wl,/usr/pkgsrc/security/libgcrypt/work/.buildlink/lib 
-L/usr/pkgsrc/security/libgcrypt/work/.buildlink/lib 
/usr/pkgsrc/security/libgcrypt/work/.buildlink/lib/libgpg-error.so 
/usr/pkgsrc/security/libgcrypt/work/.buildlink/lib/libintl.so  
-Wl,-R/usr/pkg/lib   -Wl,-soname -Wl,libgcrypt.so.11 -o 
.libs/libgcrypt.so.11.8.0
/usr/libexec/binutils222/elf/ld.bfd: ../mpi/.libs/libmpi.a(mpi-add.o): 
relocation R_X86_64_PC32 against undefined symbol `_gcry_mpih_add_1' can not be 
used when making a shared object; recompile with -fPIC
/usr/libexec/binutils222/elf/ld.bfd: final link failed: Bad value
*** Error code 1

The build can be fixed by removing:
patches/patch-mpi_mpi-internal.h

>How-To-Repeat:

>Fix:
Remove the patch file:
patch-mpi_mpi-internal.h