Re: pkg/48070: The printf width specifier z should be used to format that type(MISSING_SIZE_T_SUPPORT)

["OBATA Akio" <obache%netbsd.org@localhost>]

The following reply was made to PR pkg/48070; it has been noted by GNATS.

From: "OBATA Akio" <obache%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/48070: The printf width specifier z should be used to format
 that type(MISSING_SIZE_T_SUPPORT)
Date: Thu, 25 Jul 2013 20:17:43 +0900

 So, there are two problem:
 
 1. BSD/OS is also missing `z' modifier support for printf(3) format.
 2. bare `zu' modifier is used, it should be replaced with `PRIzu` instead.
 
 OK?
 
 Then, following patch should resolve those issues.
 Could you confirm it?
 
 Index: files/configure
 ===================================================================
 RCS file: /cvsroot/pkgsrc/pkgtools/pkg_install/files/configure,v
 retrieving revision 1.38
 diff -u -p -r1.38 configure
 --- files/configure     10 Feb 2013 12:46:56 -0000      1.38
 +++ files/configure     25 Jul 2013 11:14:09 -0000
 @@ -5034,7 +5034,7 @@ _ACEOF
 
 
   case $host in
 -*-*-hpux*)
 +*-*-bsdi*|*-*-hpux*)
          $as_echo "#define MISSING_SIZE_T_SUPPORT 1" >>confdefs.h
 
 
 Index: files/configure.ac
 ===================================================================
 RCS file: /cvsroot/pkgsrc/pkgtools/pkg_install/files/configure.ac,v
 retrieving revision 1.37
 diff -u -p -r1.37 configure.ac
 --- files/configure.ac  10 Feb 2013 12:46:56 -0000      1.37
 +++ files/configure.ac  25 Jul 2013 11:14:09 -0000
 @@ -133,7 +133,7 @@ AC_CHECK_SIZEOF(long long)
   AC_CHECK_SIZEOF(size_t, [#include <stdlib.h>])
 
   case $host in
 -*-*-hpux*)
 +*-*-bsdi*|*-*-hpux*)
          AC_DEFINE(MISSING_SIZE_T_SUPPORT)
          AH_TEMPLATE([MISSING_SIZE_T_SUPPORT], [
          Define to 1 if the `z' modifider for printf is missing.
 Index: files/admin/main.c
 ===================================================================
 RCS file: /cvsroot/pkgsrc/pkgtools/pkg_install/files/admin/main.c,v
 retrieving revision 1.61
 diff -u -p -r1.61 main.c
 --- files/admin/main.c  20 Apr 2010 00:39:13 -0000      1.61
 +++ files/admin/main.c  25 Jul 2013 11:14:09 -0000
 @@ -248,7 +248,7 @@ rebuild(void)
          iterate_pkg_db(add_pkg, &count);
 
          printf("\n");
 -       printf("Stored %" PRIzu " file%s and %zu explicit director%s"
 +       printf("Stored %" PRIzu " file%s and %" PRIzu " explicit director%s"
              " from %"PRIzu " package%s in %s.\n",
              count.files, count.files == 1 ? "" : "s",
              count.directories, count.directories == 1 ? "y" : "ies",
 
 
 -- 
 OBATA Akio / obache%NetBSD.org@localhost