pkg/48218: tmux fails on timersub requirement

[netbsd%bnjf.id.au@localhost]

>Number:         48218
>Category:       pkg
>Synopsis:       tmux fails on timersub requirement
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Sep 16 23:40:00 +0000 2013
>Originator:     Brad Forschinger
>Release:        Solaris 10
>Organization:
>Environment:
SunOS x 5.10 Generic_147147-26 sun4v sparc sun4v

>Description:

misc/tmux fails to build on Solaris

during the build:
source='server-client.c' object='server-client.o' libtool=no  DEPDIR=.deps 
depmode=none /usr/pkg/bin/pdksh ./etc/depcomp  cc -DPACKAGE_NAME=\"tmux\" 
-DPACKAGE_TARNAME=\"tmux\" -DPACKAGE_VERSION=\"1.8\" -DPACKAGE_STRING=\"tmux\ 
1.8\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"tmux\" 
-DVERSION=\"1.8\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_CURSES_H=1 
-DHAVE_DIRENT_H=1 -DHAVE_FCNTL_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 
-DHAVE_B64_NTOP=1 -DHAVE_LIBXNET=1 -DHAVE_CLOSEFROM=1 -DHAVE_DAEMON=1 
-DHAVE_SETENV=1 -DHAVE_STRLCPY=1 -DHAVE_STRLCAT=1 -DHAVE_ASPRINTF=1 
-DHAVE_DECL_OPTARG=0 -DHAVE_DECL_OPTIND=0 -DHAVE_DECL_OPTRESET=0 
-DHAVE_BZERO=1 -DHAVE_SYSCONF=1 -DHAVE_PROC_PID=1 -I.    -I/usr/pkg/include 
-D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED     -D_XPG4_2 -D__EXTENSIONS__ 
-D_POSIX_PT
HREAD_SEMANTICS  -O -O -I/usr/pkg/include       -erroff=E_EMPTY_DECLARATION -c 
server-client.c
"server-client.c", line 351: warning: implicit function declaration: timersub

and when linking:
cc  -O -O -I/usr/pkg/include       -erroff=E_EMPTY_DECLARATION  -L/usr/pkg/lib 
-Wl,-R/usr/pkg/lib -o tmux arguments.o attributes.o  cfg.o client.o clock.o  
cmd-attach-session.o cmd-bind-key.o  cmd-break-pane.o cmd-capture-pane.o  
cmd-choose-buffer.o cmd-choose-client.o  cmd-choose-list.o cmd-choose-tree.o  
cmd-clear-history.o cmd-clock-mode.o  cmd-command-prompt.o cmd-confirm-before.o 
 cmd-copy-mode.o cmd-delete-buffer.o  cmd-detach-client.o cmd-display-message.o 
 cmd-display-panes.o cmd-find-window.o  cmd-has-session.o cmd-if-shell.o  
cmd-join-pane.o cmd-kill-pane.o  cmd-kill-server.o cmd-kill-session.o  
cmd-kill-window.o cmd-link-window.o  cmd-list-buffers.o cmd-list-clients.o  
cmd-list-commands.o cmd-list-keys.o  cmd-list-panes.o cmd-list-sessions.o  
cmd-list-windows.o cmd-list.o  cmd-load-buffer.o cmd-lock-server.o  
cmd-move-window.o cmd-new-session.o  cmd-new-window.o cmd-paste-buffer.o  
cmd-pipe-pane.o cmd-queue.o  cmd-refresh-client.o cmd-rename-session.o  
cmd-rename-w
 indow.o cmd-resize-pane.o  cmd-respawn-pane.o cmd-respawn-window.o  
cmd-rotate-window.o cmd-run-shell.o  cmd-save-buffer.o cmd-select-layout.o  
cmd-select-pane.o cmd-select-window.o  cmd-send-keys.o cmd-server-info.o  
cmd-set-buffer.o cmd-set-environment.o  cmd-set-option.o cmd-show-environment.o 
 cmd-show-messages.o cmd-show-options.o  cmd-source-file.o cmd-split-window.o  
cmd-start-server.o cmd-string.o  cmd-suspend-client.o cmd-swap-pane.o  
cmd-swap-window.o cmd-switch-client.o  cmd-unbind-key.o cmd-unlink-window.o  
cmd-wait-for.o cmd.o colour.o  control.o control-notify.o environ.o  format.o 
grid-cell.o grid-view.o  grid.o input-keys.o input.o  job.o key-bindings.o 
key-string.o  layout-custom.o layout-set.o layout.o  log.o mode-key.o names.o  
notify.o options-table.o options.o  paste.o resize.o screen-redraw.o  
screen-write.o screen.o  server-client.o server-fn.o  server-window.o server.o 
session.o  signal.o status.o tmux.o  tty-acs.o tty-keys.o tty-term.o  tty.o 
utf8.o 
 window-choose.o  window-clock.o window-copy.o window.o  xmalloc.o xterm-keys.o 
osdep-sunos.o forkpty-sunos.o  imsg.o imsg-buffer.o         fgetln.o getopt.o  
strcasestr.o strsep.o vis.o unvis.o  strtonum.o   -lxnet -lsocket -lnsl 
-lcurses -levent -lrt  -lresolv
Undefined                       first referenced
 symbol                             in file
timersub                            server-client.o

>How-To-Repeat:

build misc/tmux on Solaris
>Fix:

from 
http://mail.gnu.org.ua/mailman/listarchive/bug-mailfromd/2011-03/msg00004.html

+#ifndef timersub
+# define timersub(a, b, result)                                                
\
+       do {                                                            \
+               (result)->tv_sec = (a)->tv_sec - (b)->tv_sec;           \
+               (result)->tv_usec = (a)->tv_usec - (b)->tv_usec;        \
+               if ((result)->tv_usec < 0) {                            \
+                       --(result)->tv_sec;                             \
+                       (result)->tv_usec += 1000000;                   \
+               }                                                       \
+       } while (0)
+#endif