pkg/48525: lang/mono2 patch-ab fix for libdl is incorrect

[rhansen%bbn.com@localhost]

>Number:         48525
>Category:       pkg
>Synopsis:       lang/mono2 patch-ab fix for libdl is incorrect
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 15 19:40:00 +0000 2014
>Originator:     Richard Hansen
>Release:        2013Q4
>Organization:
>Environment:
NetBSD foo 6.1 NetBSD 6.1 (GENERIC) ... i386
>Description:
lang/mono2/patches/patch-ab contains this hunk altering configure:

--- configure.orig      2012-02-01 20:48:05.000000000 +0000
+++ configure
@@ -3741,7 +3741,7 @@ $as_echo "#define MINGW_CROSS_COMPILE 1"
                CPPFLAGS="$CPPFLAGS -DPLATFORM_BSD"
                libmono_ldflags="-pthread"
                need_link_unlink=yes
-               libdl="-ldl"
+               libdl="-ldl /libexec/ld.elf_so"
                libgc_threads=pthreads
                with_sigaltstack=no
                use_sigposix=yes

This change is incorrect; there is no libdl in NetBSD, and manually 
linking against /libexec/ld.elf_so seems wrong.

AFAIK, ${libdl} is only used when --with-gc=boehm is passed to 
configure, which it's not, so this isn't currently causing a problem.
>How-To-Repeat:

>Fix:
diff --git a/pkgsrc/lang/mono2/distinfo b/pkgsrc/lang/mono2/distinfo
index 7956ab1..7596a03 100644
--- a/pkgsrc/lang/mono2/distinfo
+++ b/pkgsrc/lang/mono2/distinfo
@@ -4,7 +4,7 @@ SHA1 (mono-2.10.9.tar.bz2) = 
1a6e8c5a0c3d88d87982259aa04402e028a283de
 RMD160 (mono-2.10.9.tar.bz2) = ac9784c413eb2cdb490750a86a96cce5c11ad5bd
 Size (mono-2.10.9.tar.bz2) = 34038017 bytes
 SHA1 (patch-aa) = f3c88247c143cba6d0475f1dabb653adbc841bdb
-SHA1 (patch-ab) = bc7c65758bd4c24340ab75f42e6fae9831c0498b
+SHA1 (patch-ab) = 10eb6f4453c626f0bedce4b0ce6519ba6aea4d5f
 SHA1 (patch-ac) = 78f3b0786480e066959cc191e3f45d3f773220e2
 SHA1 (patch-ad) = 2dc253928695966b5310457b0cec52cd919a4851
 SHA1 (patch-ae) = 2b032ad658e8aa23c4e3825474d2d284b00557cd
diff --git a/pkgsrc/lang/mono2/patches/patch-ab 
b/pkgsrc/lang/mono2/patches/patch-ab
index c3a9915..074f28e 100644
--- a/pkgsrc/lang/mono2/patches/patch-ab
+++ b/pkgsrc/lang/mono2/patches/patch-ab
@@ -18,7 +18,7 @@ Support 64-bit SunOS.
                libmono_ldflags="-pthread"
                need_link_unlink=yes
 -              libdl="-ldl"
-+              libdl="-ldl /libexec/ld.elf_so"
++              libdl=
                libgc_threads=pthreads
                with_sigaltstack=no
                use_sigposix=yes