I seem to have dropped GNATS off the address list. On Monday, April 14, 2014 thequux%upstandinghackers.com@localhost wrote: > A very minor point about > https://github.com/UpstandingHackers/hammer/commit/849178d60bedbf08842425bc77b428236ab769aa > > I think a better cast would be to unsigned char, since you already > should have checked for -1, and the only other valid values are > unsigned char. > > http://netbsd.gw.com/cgi-bin/man-cgi?ctype++NetBSD-current > explains it in more detail. Thanks for catching this, particularly considering that a negative value will index before the beginning of the ctype array and that function is designed to handle arbitrary octets. I'll get that fixed. > What do you want to do about the language plugins for the package? > Should they become optional dependencies? > > Various packages already contain options.mk files if you need > inspiration how that's done. Having the language bindings be optional dependencies makes sense. I'll get that taken care of by the time we release 1.0.0. --tq
Attachment:
signature.asc
Description: This is a digitally signed message part.