pkgsrc-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/48776: www/firefox 29.0 cannot convert 'float**' to 'mozilla::AudioDataValue** {aka short int**}'
The following reply was made to PR pkg/48776; it has been noted by GNATS.
From: David Shao <davshao%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc:
Subject: Re: pkg/48776: www/firefox 29.0 cannot convert 'float**' to
'mozilla::AudioDataValue** {aka short int**}'
Date: Fri, 2 May 2014 14:04:08 -0700
www/firefox 29.0 builds and is replaced successfully on DragonFly
3.7-DEVELOPMENT x86_64 as of current cvs pkgsrc through
Module Name: pkgsrc
Date: Fri May 2 12:34:39 UTC 2014
Modified Files:
pkgsrc/www/firefox: distinfo
pkgsrc/www/firefox/patches: patch-aa
Log Message:
Fix build under DragonFly, PR pkg/48776
This PR should possibly be kept open only to see if FreeBSD and
OpenBSD also should have the same patch applied to configure.in. From
the documentation in configure.in, patch-aa, it appears that desktop
systems should never have had
MOZ_SAMPLE_TYPE_S16=1
set:
dnl Use integers over floats for audio on B2G and Android, because audio
dnl backends for those platforms don't support floats.
-if test "$OS_TARGET" = "Android"; then
+case "$OS_TARGET" in
+Android|FreeBSD|OpenBSD)
MOZ_SAMPLE_TYPE_S16=1
AC_DEFINE(MOZ_SAMPLE_TYPE_S16)
AC_SUBST(MOZ_SAMPLE_TYPE_S16)
-else
+ ;;
+*)
MOZ_SAMPLE_TYPE_FLOAT32=1
AC_DEFINE(MOZ_SAMPLE_TYPE_FLOAT32)
AC_SUBST(MOZ_SAMPLE_TYPE_FLOAT32)
-fi
+ ;;
+esac
Futhermore sound has not been tested in DragonFly.
Thanks for the immediate fix!
Home |
Main Index |
Thread Index |
Old Index