pkg/48814: x11/kdelibs4 after giflib-5.1.0 update: too few arguments to function 'int DGifCloseFile(GifFileType*, int*)

[davshao%gmail.com@localhost]

>Number:         48814
>Category:       pkg
>Synopsis:       x11/kdelibs4 after giflib-5.1.0 update: too few arguments to 
>function 'int DGifCloseFile(GifFileType*, int*)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 17 07:55:00 +0000 2014
>Originator:     David Shao
>Release:        DragonFly 3.7-DEVELOPMENT x86_64
>Organization:
>Environment:
DragonFly  3.7-DEVELOPMENT DragonFly v3.7.1.1191.g76c21-DEVELOPMENT #1: Thu May 
15 08:51:44 PDT 2014     xxxxx@:/usr/obj/usr/src/sys/X86_64_GENERIC  x86_64

>Description:
Using latest cvs pkgsrc on DragonFly 3.7-DEVELOPMENT x86_64, after the update 
to giflib 5.1.0, x11/kdelibs4 fails to rebuild after
pkg_rolling-replace -uv

[ 80%] Building CXX object 
khtml/CMakeFiles/khtml.dir/imload/decoders/pngloader.o
/usr/pkgsrc/x11/kdelibs4/work/kdelibs-4.11.5/khtml/imload/decoders/pngloader.cpp:
 In member function 'void khtmlImLoad::PNGLoader::haveRow(unsigned int, int, 
unsigned char*)':
/usr/pkgsrc/x11/kdelibs4/work/kdelibs-4.11.5/khtml/imload/decoders/pngloader.cpp:200:22:
 warning: unused variable 'pngDepth' [-Wunused-variable]
/usr/pkgsrc/x11/kdelibs4/work/kdelibs-4.11.5/khtml/imload/decoders/pngloader.cpp:
 In member function 'virtual int khtmlImLoad::PNGLoader::processData(uchar*, 
int)':
/usr/pkgsrc/x11/kdelibs4/work/kdelibs-4.11.5/khtml/imload/decoders/pngloader.cpp:242:17:
 warning: argument 'length' might be clobbered by 'longjmp' or 'vfork' 
[-Wclobbered]
[ 80%] Building CXX object 
khtml/CMakeFiles/khtml.dir/imload/decoders/gifloader.o
/usr/pkgsrc/x11/kdelibs4/work/kdelibs-4.11.5/khtml/imload/decoders/gifloader.cpp:
 In member function 'virtual int khtmlImLoad::GIFLoader::processEOF()':
/usr/pkgsrc/x11/kdelibs4/work/kdelibs-4.11.5/khtml/imload/decoders/gifloader.cpp:372:31:
 error: too few arguments to function 'int DGifCloseFile(GifFileType*, int*)'
In file included from 
/usr/pkgsrc/x11/kdelibs4/work/kdelibs-4.11.5/khtml/imload/decoders/gifloader.cpp:45:0:
/usr/pkgsrc/x11/kdelibs4/work/.buildlink/include/gif_lib.h:183:9: note: 
declared here
/usr/pkgsrc/x11/kdelibs4/work/kdelibs-4.11.5/khtml/imload/decoders/gifloader.cpp:381:35:
 error: too few arguments to function 'int DGifCloseFile(GifFileType*, int*)'
In file included from 
/usr/pkgsrc/x11/kdelibs4/work/kdelibs-4.11.5/khtml/imload/decoders/gifloader.cpp:45:0:
/usr/pkgsrc/x11/kdelibs4/work/.buildlink/include/gif_lib.h:183:9: note: 
declared here
/usr/pkgsrc/x11/kdelibs4/work/kdelibs-4.11.5/khtml/imload/decoders/gifloader.cpp:393:35:
 error: too few arguments to function 'int DGifCloseFile(GifFileType*, int*)'
In file included from 
/usr/pkgsrc/x11/kdelibs4/work/kdelibs-4.11.5/khtml/imload/decoders/gifloader.cpp:45:0:
/usr/pkgsrc/x11/kdelibs4/work/.buildlink/include/gif_lib.h:183:9: note: 
declared here
/usr/pkgsrc/x11/kdelibs4/work/kdelibs-4.11.5/khtml/imload/decoders/gifloader.cpp:577:27:
 error: too few arguments to function 'int DGifCloseFile(GifFileType*, int*)'
In file included from 
/usr/pkgsrc/x11/kdelibs4/work/kdelibs-4.11.5/khtml/imload/decoders/gifloader.cpp:45:0:
/usr/pkgsrc/x11/kdelibs4/work/.buildlink/include/gif_lib.h:183:9: note: 
declared here
khtml/CMakeFiles/khtml.dir/build.make:5184: recipe for target 
'khtml/CMakeFiles/khtml.dir/imload/decoders/gifloader.o' failed
gmake[2]: *** [khtml/CMakeFiles/khtml.dir/imload/decoders/gifloader.o] Error 1
CMakeFiles/Makefile2:30276: recipe for target 'khtml/CMakeFiles/khtml.dir/all' 
failed
gmake[1]: *** [khtml/CMakeFiles/khtml.dir/all] Error 2
Makefile:146: recipe for target 'all' failed

According to the NEWS for giflib 5.1.0:

http://fossies.org/linux/giflib/NEWS

"A small change to the API: DGifClose() and EGifClose() now take a
pointer-to-int second argument (like the corresponding openers)
where a diagnostic code will be deposited when they return
GIF_ERROR.  This replaces the old behavior in which the GifFile
structure was left unfreed so the Error member in it could be filled
and remain available.  The change was was required because it's
not always possible to free the struct afterwards."

>How-To-Repeat:

>Fix: