pkgsrc-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/48939: www/apache24/patches/patch-am is wrong
The following reply was made to PR pkg/48939; it has been noted by GNATS.
From: Thomas Klausner <wiz%NetBSD.org@localhost>
To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
Cc:
Subject: Re: pkg/48939: www/apache24/patches/patch-am is wrong
Date: Mon, 23 Jun 2014 13:42:47 +0200
Looking at the diff:
> RCS file: /cvsroot/pkgsrc/www/apache24/patches/patch-am,v
> retrieving revision 1.1.1.1
> diff -u -u -r1.1.1.1 patch-am
> --- patches/patch-am 13 Apr 2012 18:50:49 -0000 1.1.1.1
> +++ patches/patch-am 23 Jun 2014 10:07:07 -0000
> @@ -7,7 +7,7 @@
> /* Scoreboard file, if there is one */
> #ifndef DEFAULT_SCOREBOARD
> -#define DEFAULT_SCOREBOARD "logs/apache_runtime_status"
> -+#define DEFAULT_SCOREBOARD DEFAULT_REL_RUNTIMEDIR
> "logs/apache_runtime_status"
> ++#define DEFAULT_SCOREBOARD DEFAULT_REL_RUNTIMEDIR
> "/logs/apache_runtime_status"
> #endif
>
> /* Scoreboard info on a process is, for now, kept very brief ---
>
It seems that upstream expects DEFAULT_REL_RUNTIMEDIR to end with a slash.
So shouldn't we fix DEFAULT_REL_RUNTIMEDIR to end with a slash instead?
Thomas
Home |
Main Index |
Thread Index |
Old Index