Re: pkg/36974 (xorp doesn't compile targeted at arm)

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/36974; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/36974 (xorp doesn't compile targeted at arm)
Date: Mon, 29 Dec 2014 06:55:40 +0000

 On Sun, Aug 01, 2010 at 12:10:05AM +0000, David Holland wrote:
  >  Maybe we should just disable the warning... if they think casting from
  >  sockaddr_in* to sockaddr_in6* is going to be valid, presumably it's
  >  because the thing was originally allocated as a sockaddr_storage and
  >  it therefore should (one would hope) be properly aligned.
 
 So, in the current code, they proclaim in utility.h where the casts
 are that it shouldn't cause problems, and launder the pointers through
 void * to try to fool the compiler, which I expect probably doesn't
 work.
 
 I think we're better off pretending that they're correct, as reworking
 the code (especially since it depends heavily on C++ overload
 resolution) is an upstream-level problem... given that nobody here has
 done it in the past four years, probably nobody will.
 
 There's already a transform for disabling -Werror on clang; I'm going
 to make that unconditional.
 
 (Especially since without that the package doesn't build at all with
 gcc 4.8 for unrelated reasons.)
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost