Re: pkg/49080 (parralel/openmpi seems to miss some files in PLIST)

["OBATA Akio" <obata%lins.jp@localhost>]

The following reply was made to PR pkg/49080; it has been noted by GNATS.

From: "OBATA Akio" <obata%lins.jp@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/49080 (parralel/openmpi seems to miss some files in PLIST)
Date: Wed, 14 Jan 2015 17:09:59 +0900

 On Wed, 14 Jan 2015 16:45:01 +0900, Joerg Sonnenberger <joerg%britannica.bec.de@localhost> wrote:
 
 >  >  -PLIST_SRC?=            ${PLIST_SRC_DFLT}
 >  >  +PLIST_SRC+=            ${PLIST_SRC_DFLT}
 >  >
 >  >    # This is the path to the generated PLIST file.
 >  >    PLIST=         ${WRKDIR}/.PLIST
 >  >
 >  >
 > This part is wrong. It is explicitly meant to make it possible to
 >  override the default.
 
 Any particular reason to put PLIST.Linux whereas it must not be
 used even on Linux?
 i.e, any particular reason to override the default?
 Just prevent to use such ambiguous PLIST file name, it's easier solution.
 
 >  >  Following change will resolve the issue in the package:
 >  >
 >  >  Index: options.mk
 >  >  ===================================================================
 >  >  RCS file: /cvsroot/pkgsrc/parallel/openmpi/options.mk,v
 >  >  retrieving revision 1.7
 >  >  diff -u -r1.7 options.mk
 >  >  --- options.mk  22 May 2014 13:24:49 -0000      1.7
 >  >  +++ options.mk  14 Jan 2015 02:35:55 -0000
 >  >  @@ -35,4 +35,4 @@
 >  >    CONFIGURE_ARGS+=       --without-sge
 >  >    .endif
 >  >
 >  >  -PLIST_SRC+=            PLIST
 >  >  +PLIST_SRC+=            ${PLIST_SRC_DFLT}
 > This part looks better.
 
 No, this PR represent this method is too bad, because package
 maintainers must be aware of default PLISTs, mostly redundant.
 
 Same issue also in DISTFILES with DEFAULT_DISTFILES.
 
 -- 
 OBATA Akio / obata%lins.jp@localhost