pkg/49857: Patch to fix build of archivers/arj on Darwin

[jonthn+pkgsrc%pinacea.com@localhost]

>Number:         49857
>Category:       pkg
>Synopsis:       Patch to fix build of archivers/arj on Darwin
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Apr 25 17:15:00 +0000 2015
>Originator:     Jonathan Buschmann
>Release:        
>Organization:
>Environment:
>Description:
Package archivers/arj doesn't build on Darwin 10.10

I made a patch below that fixes the issue during the build, but I'm not sure it makes the tool usable, I was able to make an archive but wasn't able to extract files afterwards I keep hitting messages :

---
Error (2): No such file or directory
Can't open
OK to extract to a new filename?
---

with no filenames displayed but if I enter a name it gets created.
>How-To-Repeat:

>Fix:
diff --git a/archivers/arj/Makefile b/archivers/arj/Makefile
index ead213c..8ee9adf 100644
--- a/archivers/arj/Makefile
+++ b/archivers/arj/Makefile
@@ -8,6 +8,7 @@ MASTER_SITES=   ${MASTER_SITE_SOURCEFORGE:=arj/}
 MAINTAINER=    pkgsrc-users%NetBSD.org@localhost
 HOMEPAGE=      http://arj.sourceforge.net/
 COMMENT=       Open-source ARJ archiver
+LICENSE=       gnu-gpl-v2

 MAKE_JOBS_SAFE=                no

diff --git a/archivers/arj/distinfo b/archivers/arj/distinfo
index f61362b..0535504 100644
--- a/archivers/arj/distinfo
+++ b/archivers/arj/distinfo
@@ -15,5 +15,6 @@ SHA1 (patch-gnu_config.h.in) = 2cf609a6c7cb4e32441a433db3dc9cc04c23ae2a
 SHA1 (patch-gnu_configure.in) = 062f3dc1eee6f009dfdfa432bb3c138a9c28a829
 SHA1 (patch-gnu_makefile.in) = db8a0afa61f49242e9fd601d5fc3167cf75f748b
 SHA1 (patch-integr.c) = fade32219b21ac3382028bf23ee4171d8d095b5f
+SHA1 (patch-msgbind.c) = e3faf958f2272bf946b036fbf62ecfa665f86abc
 SHA1 (patch-register.c) = 8d81e663b499a45f7faa52b16a6cee47394cd09c
 SHA1 (patch-uxspec.c) = 24a22fa2822704e620b38df12b76ef88fe908863
diff --git a/archivers/arj/patches/patch-msgbind.c b/archivers/arj/patches/patch-msgbind.c
new file mode 100644
index 0000000..22a66c0
--- /dev/null
+++ b/archivers/arj/patches/patch-msgbind.c
@@ -0,0 +1,15 @@
+$NetBSD$
+
+Fix overlap string copy
+
+--- msgbind.c.orig     2015-04-25 16:26:29.000000000 +0000
++++ msgbind.c
+@@ -578,7 +578,7 @@ int main(int argc, char **argv)
+    }
+    strcat(pool[tpool].data, msgname);
+    strcat(pool[tpool].data, ", ");
+-   strcpy(msg_buffer, msg_buffer+1);
++   memmove(msg_buffer, msg_buffer+1, strlen(msg_buffer));
+    buf_len=strlen(msg_buffer);
+    msg_buffer[--buf_len]='\0';
+    patch_string(msg_buffer);