Re: pkg/49934: libgtop doesn't build after the sysvcompat modularization

[Kamil Rytarowski <n54%gmx.com@localhost>]

The following reply was made to PR pkg/49934; it has been noted by GNATS.

From: Kamil Rytarowski <n54%gmx.com@localhost>
To: Patrick Welche <prlw1%cam.ac.uk@localhost>, gnats-bugs%NetBSD.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
 pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/49934: libgtop doesn't build after the sysvcompat modularization
Date: Fri, 05 Jun 2015 22:06:32 +0000

 On 05.06.2015 16:08, Patrick Welche wrote:
 > Looks good to me.
 > 
 > _KERNEL hasn't been needed for struct {shm,sem}info since
 > /*     $NetBSD: sem.h,v 1.12 2000/06/02 15:53:05 simonb Exp $  */
 > /*     $NetBSD: shm.h,v 1.26 2000/06/02 15:53:05 simonb Exp $  */
 > 
 > 
 > commit 752750474bdbaefdc14dc629933e21fbef37a00e
 > Author: simonb <simonb>
 > Date:   Fri Jun 2 15:53:03 2000 +0000
 > 
 >     Add new sysctl node "KERN_SYSVIPC_INFO" with "KERN_SYSVIPC_MSG_INFO",
 >     "KERN_SYSVIPC_SEM_INFO" and "KERN_SYSVIPC_SHM_INFO" to return the
 >     info and data structures for the relevent SysV IPC types.  The return
 >     structures use fixed-size types and should be compat32 safe.  All
 >     user-visible changes are protected with
 >         #if !defined(_POSIX_C_SOURCE) && !defined(_XOPEN_SOURCE)
 >     
 >     Make all variable declarations extern in msg.h, sem.h and shm.h and
 >     add relevent variable declarations to sysv_*.c and remove unneeded
 >     header files from those .c files.
 >     
 >     Make compat14 SysV IPC conversion functions and sysctl_file() static.
 >     
 >     Change the data pointer to "void *" in sysctl_clockrate(),
 >     sysctl_ntptime(), sysctl_file() and sysctl_doeproc().
 > 
 > Upstream libgtop is in a sorry state, e.g., Juan Pardines' processor
 > affinity support patch from 2008 is still sitting in bugzilla.gnome.org.
 > 
 > I went for a possibly slightly more blunt patch (attached).
 > 
 > Thoughts?
 > 
 
 
 Looks good to me.