pkg/49955: rxvt config file handling broken

[martin%NetBSD.org@localhost]

>Number:         49955
>Category:       pkg
>Synopsis:       rxvt config file handling broken
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 09 11:40:00 +0000 2015
>Originator:     Martin Husemann
>Release:        NetBSD 7.99.18
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD supremacy.duskware.de 7.99.18 NetBSD 7.99.18 (ERLITE) #32: Mon Jun 8 21:14:35 CEST 2015 martin%night-owl.duskware.de@localhost:/usr/src/sys/arch/evbmips/compile/ERLITE evbmips
Architecture: mips64eb
Machine: evbmips
>Description:

The x11/rxvt package has a hack (maybe even introduced by myself) that tries
to install a suplied default config file by checking wether it exists already
in the target directory. This used to work fine in the ancient days, but with
DESTDIR/staged installs and binary pkgs it does not make any sense at all.

Please someone fix it and apply stock config file handling to the "Rxvt"
file.

>How-To-Repeat:

Try to build the pkg while it is already installed on the build machine.

See this sniplet in the makefile:

INSTALLATION_DIRS=	lib/X11/app-defaults

pre-install:
	if [ ! -f ${PREFIX}/lib/X11/app-defaults/Rxvt ]; then \
		${INSTALL_DATA} ${FILESDIR}/Rxvt ${DESTDIR}${PREFIX}/lib/X11/app-defaults; \
	fi


>Fix:
n/a