Re: pkg/50188: pkgtools/pkg_install DragonFly 4.3 /usr/lib/libbz2.so.2: error adding symbols

[David Shao <davshao%gmail.com@localhost>]

The following reply was made to PR pkg/50188; it has been noted by GNATS.

From: David Shao <davshao%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/50188: pkgtools/pkg_install DragonFly 4.3 /usr/lib/libbz2.so.2:
 error adding symbols
Date: Wed, 2 Sep 2015 20:41:01 -0700

 This is the current status of getting pkgtools/pkg_install to build on
 DragonFly 4.3-DEVELOPMENT, and I conjecture FreeBSD 11 current.
 
 DragonFly 4.3-DEVELOPMENT has in base libbz2 and libz.  When I specify
 in pkg_install's Makefile
 
 LDFLAGS+=  -lbz2 -lz
 or
 LIBS+=  -lbz2 -lz
 
 these flags fail to be picked up.
 
 This is apparently the goal:
 
 cc -lssl -lcrypto -L/usr/pkgsrc/pkgtools/pkg_install/work/libfetch
 -L/usr/pkgsrc/pkgtools/pkg_install/work/netpgpverify
 -L/usr/pkgsrc/pkgtools/pkg_install/work/libnbcompat -L/usr/lib
 -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib -L../lib -o pkg_info main.o
 perform.o show.o -linstall -larchive -lfetch -lnetpgpverify -lnbcompat
 -lssl -lcrypto -lbz2 -lz
 
 Instead I have to use the following patch where I do not think I am
 even putting the flags in the correct place in the Makefile.in's.
 
 diff -Nur pkg_install.orig/files/add/Makefile.in
 pkg_install/files/add/Makefile.in
 --- pkg_install.orig/files/add/Makefile.in    2015-09-01
 05:14:06.000000000 -0700
 +++ pkg_install/files/add/Makefile.in    2015-09-02 13:17:50.966930000 -0700
 @@ -22,7 +22,7 @@
 
  LIBS=        -linstall -larchive -lfetch -lnetpgpverify
  .if !empty(SSL_SUPPORT)
 -LIBS+=        -lssl -lcrypto
 +LIBS+=        -lssl -lcrypto -lbz2 -lz
  .endif
  LIBS+=        @LIBS@
 
 diff -Nur pkg_install.orig/files/admin/Makefile.in
 pkg_install/files/admin/Makefile.in
 --- pkg_install.orig/files/admin/Makefile.in    2015-09-01
 05:14:06.000000000 -0700
 +++ pkg_install/files/admin/Makefile.in    2015-09-02 13:19:30.166034000 -0700
 @@ -30,7 +30,7 @@
  .if empty(BOOTSTRAP)
  LIBS=        -linstall -larchive -lfetch -lnetpgpverify
  .if !empty(SSL_SUPPORT)
 -LIBS+=        -lssl -lcrypto
 +LIBS+=        -lssl -lcrypto -lbz2 -lz
  CFLAGS+=    -DHAVE_SSL
  .endif
  LIBS+=        @LIBS@
 diff -Nur pkg_install.orig/files/create/Makefile.in
 pkg_install/files/create/Makefile.in
 --- pkg_install.orig/files/create/Makefile.in    2015-09-01
 05:14:06.000000000 -0700
 +++ pkg_install/files/create/Makefile.in    2015-09-02 13:19:03.446276000 -0700
 @@ -28,7 +28,7 @@
  .if empty(BOOTSTRAP)
  LIBS=        -linstall -larchive -lfetch -lnetpgpverify @LIBS@
  .if !empty(SSL_SUPPORT)
 -LIBS+=        -lssl -lcrypto
 +LIBS+=        -lssl -lcrypto -lbz2 -lz
  .endif
  CPPFLAGS=    @CPPFLAGS@ -I. -I$(srcdir) -I../lib
  OBJS=    main.o perform.o pl.o util.o build.o
 diff -Nur pkg_install.orig/files/delete/Makefile.in
 pkg_install/files/delete/Makefile.in
 --- pkg_install.orig/files/delete/Makefile.in    2015-09-01
 05:14:06.000000000 -0700
 +++ pkg_install/files/delete/Makefile.in    2015-09-02 13:18:41.056479000 -0700
 @@ -18,7 +18,7 @@
  LIBS=        -linstall -larchive -lfetch -lnetpgpverify @LIBS@
 
  .if !empty(SSL_SUPPORT)
 -LIBS+=        -lssl -lcrypto
 +LIBS+=        -lssl -lcrypto -lbz2 -lz
  .endif
 
  CPPFLAGS=    @CPPFLAGS@ -I. -I$(srcdir) -I../lib -DBINDIR=\"$(sbindir)\"
 diff -Nur pkg_install.orig/files/info/Makefile.in
 pkg_install/files/info/Makefile.in
 --- pkg_install.orig/files/info/Makefile.in    2015-09-01
 05:14:06.000000000 -0700
 +++ pkg_install/files/info/Makefile.in    2015-09-02 13:18:23.256639000 -0700
 @@ -19,7 +19,7 @@
  .if empty(BOOTSTRAP)
  LIBS=        -linstall -larchive -lfetch -lnetpgpverify @LIBS@
  .if !empty(SSL_SUPPORT)
 -LIBS+=        -lssl -lcrypto
 +LIBS+=        -lssl -lcrypto -lbz2 -lz
  .endif
  CPPFLAGS=    @CPPFLAGS@ -I. -I$(srcdir) -I../lib
  .else
 
 In addition I believe it is possible the following undefined symbols
 will eventually cause trouble and need to be addressed as well:
 
 checking md5.h usability... yes
 checking md5.h presence... yes
 checking for md5.h... yes
 checking for MD5Init in md5.h... yes
 checking for md5.h... (cached) yes
 checking rmd160.h usability... yes
 checking rmd160.h presence... yes
 checking for rmd160.h... yes
 checking sha1.h usability... no
 checking sha1.h presence... no
 checking for sha1.h... no
 checking sha2.h usability... no
 checking sha2.h presence... no
 checking for sha2.h... no
 checking for MD5File... no
 checking for RMD160File... no
 checking for SHA1File... no
 checking for SHA512_File... no
 ...
 cc -D_LARGEFILE_SOURCE -D_LARGE_FILES -D_FILE_OFFSET_BITS=64
 -DDEF_UMASK=0022 -I/usr/pkgsrc/pkgtools/pkg_install/work/libfetch
 -I/usr/pkgsrc/pkgtools/pkg_install/work -DHAVE_NBCOMPAT_H=1
 -I/usr/pkgsrc/pkgtools/pkg_install/work/libnbcompat -I/usr/include
 -D__DBINTERFACE_PRIVATE -I. -I.  -g -I/usr/include -DHAVE_CONFIG_H -c
 unvis.c
 unvis.c: In function 'unvis':
 unvis.c:92:9: warning: implicit declaration of function
 '__nbcompat_unvis13' [-Wimplicit-function-declaration]
   return __nbcompat_unvis13(cp, (int)c, astate, flag);
          ^
 ...
 cc -g -I/usr/include -D_LARGEFILE_SOURCE -D_LARGE_FILES
 -D_FILE_OFFSET_BITS=64 -DDEF_UMASK=0022
 -I/usr/pkgsrc/pkgtools/pkg_install/work/libfetch
 -I/usr/pkgsrc/pkgtools/pkg_install/work -DHAVE_NBCOMPAT_H=1
 -I/usr/pkgsrc/pkgtools/pkg_install/work/libnbcompat -I/usr/include -c
 digest.c
 digest.c: In function 'digest_init':
 digest.c:131:3: warning: implicit declaration of function 'RMD160Init'
 [-Wimplicit-function-declaration]
    RMD160Init(&hash->u.rmd160ctx);
    ^
 digest.c: In function 'digest_update':
 digest.c:215:3: warning: implicit declaration of function
 'RMD160Update' [-Wimplicit-function-declaration]
    RMD160Update(hash->ctx, data, (unsigned)length);
    ^
 digest.c: In function 'digest_final':
 digest.c:247:3: warning: implicit declaration of function
 'RMD160Final' [-Wimplicit-function-declaration]
    RMD160Final(out, hash->ctx);
    ^
 digest.c:253:3: warning: implicit declaration of function
 'netpgpv_SHA512_Final' [-Wimplicit-function-declaration]
    netpgpv_SHA512_Final(out, hash->ctx);
    ^