pkg/51049: www/seamonkey creates extra dir during build

[dholland%netbsd.org@localhost]

>Number:         51049
>Category:       pkg
>Synopsis:       www/seamonkey creates extra dir during build
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Apr 06 02:30:00 +0000 2016
>Originator:     David A. Holland
>Release:        NetBSD 7.99.1 (old but irrelevant), pkgsrc 20160403
>Organization:
>Environment:
System: NetBSD valkyrie 7.99.1 NetBSD 7.99.1 (VALKYRIE) #18: Fri Feb  5 15:35:14 EST 2016  dholland@valkyrie:/usr/src/sys/arch/amd64/compile/VALKYRIE amd64
Architecture: x86_64
Machine: amd64
>Description:

Building in www/seamonkey results in the creation of
www/seamonkey/build as well as www/seamonkey/work. Lack of write
permission in www/seamonkey (or I think actually work/../build if one
puts workdirs elsewhere) causes the build to fail.

A directory work/build is also created, and this is used for building.
I think the upper-level one is accidental. I think the problem is
these lines from mozilla-common.mk:

# Build outside ${WRKSRC}
# Try to avoid conflict with config/makefiles/xpidl/Makefile.in
OBJDIR=	       		../build
CONFIGURE_DIRS=			${OBJDIR}

which is confusing pkgsrc (or maybe just bmake, since OBJDIR is very
magic in bad ways) into doing some of the wrong things.

>How-To-Repeat:

make

>Fix:

not sure.