pkg/51157: EVAL_PREFIX does not work

[triaxx%triaxx.org@localhost]

>Number:         51157
>Category:       pkg
>Synopsis:       EVAL_PREFIX does not work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun May 22 12:05:00 +0000 2016
>Originator:     Frédéric Fauberteau
>Release:        pkgsrc-2016Q1
>Organization:
>Environment:
NetBSD trashware 7.0_STABLE NetBSD 7.0_STABLE (TRASHWARE) #1: Sat Dec  5 19:26:52 CET 2015  triaxx@hydralisk:/home/triaxx/dev/nbsd/netbsd-7/usr/objs/sys/arch/amd64/compile/TRASHWARE amd64
>Description:
I tried to change a package using EVAL_PREFIX but this variable does not seem used any more (grep -R "EVAL_PREFIX" /usr/pkgsrc/mk/* gives nothing).

For instance /usr/pkgsrc/mk/compiler/f2c:
--- pkgsrc/mk/compiler/f2c.mk	2013/05/09 23:37:26	1.16
+++ pkgsrc/mk/compiler/f2c.mk	2015/11/25 13:05:47	1.17
@@ -60,9 +60,6 @@ _USE_F2C=	YES
 .if !empty(_USE_F2C:M[yY][eE][sS])
 USE_LANGUAGES+=		c
 
-EVAL_PREFIX+=		_F2CBASE=f2c
-_F2CBASE_DEFAULT=	${LOCALBASE}
-
 _F2C_DIR=	${WRKDIR}/.f2c
 _F2C_VARS=	# empty
 .  if !empty(_LANGUAGES.f2c:Mfortran) || !empty(_LANGUAGES.f2c:Mfortran77)
@@ -70,7 +67,7 @@ PKG_FC?=	${FC}
 _F2C_VARS+=	FC
 _F2C_FC:=	${_F2C_DIR}/bin/${PKG_FC:T}
 _ALIASES.FC+=	f77 g77 f2c-f77
-FCPATH=		${_F2CBASE}/bin/f2c-f77
+FCPATH=		${LOCALBASE}/bin/f2c-f77

Then I replaced EVAL_PREFIX by LOCALBASE but pkglint tells me that the LOCALBASE variable should not be used by packages and gives me some examples using EVAL_PREFIX. EVAL_PREFIX is also described in the pkgsrc guide.

Either pkgsrc is broken or both pkglint and documentation has to be fixed.


>How-To-Repeat:

>Fix: