pkg/51210: devel/menhir: can't build

[nonakap%gmail.com@localhost]

>Number:         51210
>Category:       pkg
>Synopsis:       devel/menhir: can't build
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jun 02 03:20:00 +0000 2016
>Originator:     Kimihiro Nonaka
>Release:        pkgsrc HEAD (20160601)
>Organization:
>Environment:
NetBSD netbsd 7.0_STABLE NetBSD 7.0_STABLE (NBSERVER) #18: Thu May 12 14:41:47 JST 2016  nonaka@netbsd:/home/storage/snapshot/NetBSD/7-STABLE/obj.NetBSD-amd64/amd64/sys/arch/amd64/compile/NBSERVER
>Description:
=> Checksum SHA1 OK for menhir-20160303.tar.gz
=> Checksum RMD160 OK for menhir-20160303.tar.gz
=> Checksum SHA512 OK for menhir-20160303.tar.gz
===> Installing dependencies for menhir-20160303
==========================================================================
The following variables will affect the build process of this package,
menhir-20160303.  Their current value is shown below:

        * OCAML_USE_OPT_COMPILER = yes

Based on these variables, the following variables have been set:

        * TERMCAP_TYPE = termcap

You may want to abort the process now with CTRL-C and change their value
before continuing.  Be sure to run `/usr/bin/make clean' after
the changes.
==========================================================================
=> Tool dependency gmake>=3.81: found gmake-4.1nb2
=> Tool dependency checkperms>=1.1: found checkperms-1.11nb1
=> Full dependency ocaml-findlib>=1.6: found ocaml-findlib-1.6.2
=> Full dependency ocaml>=4.03.0: found ocaml-4.03.0
===> Overriding tools for menhir-20160303
===> Extracting for menhir-20160303
===> Patching for menhir-20160303
=> Applying pkgsrc patches for menhir-20160303
=> Verifying /usr/pkgsrc/devel/menhir/patches/patch-Makefile
=> Applying pkgsrc patch /usr/pkgsrc/devel/menhir/patches/patch-Makefile
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|$NetBSD: patch-Makefile,v 1.3 2016/05/06 11:51:47 jaapb Exp $
|
|Use correct install locations and BSD_INSTALL_*
|--- Makefile.orig      2016-03-03 10:30:08.000000000 +0000
|+++ Makefile
--------------------------
Patching file Makefile using Plan A...
Hunk #1 succeeded at 45.
Hunk #2 succeeded at 164.
done
===> Creating toolchain wrappers for menhir-20160303
===> Configuring for menhir-20160303
=> Checking for portability problems in extracted files
===> Building for menhir-20160303
gmake[1]: Entering directory '/usr/obj.pkgsrc/devel/menhir/work.netbsd/menhir-20160303/src'
ocamlbuild -classic-display -no-hygiene -j 0 -cflags "-safe-string -bin-annot" menhirLib.cmo menhirLib.cmx
ocamlbuild: not found
Makefile:39: recipe for target 'library' failed
gmake[1]: *** [library] Error 127
gmake[1]: Leaving directory '/usr/obj.pkgsrc/devel/menhir/work.netbsd/menhir-20160303/src'
Makefile:116: recipe for target 'all' failed
gmake: *** [all] Error 2
*** Error code 2

Stop.
make[3]: stopped in /usr/pkgsrc/devel/menhir
*** Error code 1

Stop.
make[2]: stopped in /usr/pkgsrc/devel/menhir
*** Error code 1

Stop.
>How-To-Repeat:
make devel/menhir without devel/ocamlbuild.
>Fix:
Please apply the following patch.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/menhir/Makefile,v
retrieving revision 1.17
diff -u -p -r1.17 Makefile
--- Makefile	6 May 2016 11:51:47 -0000	1.17
+++ Makefile	2 Jun 2016 01:24:58 -0000
@@ -28,4 +28,6 @@ EGDIR=				${PREFIX}/share/examples/${PKG
 MAKE_ENV+=		EGDIR=${EGDIR:Q} USE_OCAMLFIND=true \
 	OCAML_SITELIBDIR=${OCAML_SITELIBDIR}
 
+BUILD_DEPENDS+=	ocamlbuild-[0-9]*:../../devel/ocamlbuild
+
 .include "../../mk/bsd.pkg.mk"